|WARNING| pw146581 [PATCH v3 18/22] event/cnxk: support CN20K Tx adapter fast path

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146581

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#135: FILE: drivers/event/cnxk/cn20k_eventdev.c:18:
+#define CN20K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops)                                               \
+	enq_op = enq_ops[dev->tx_offloads & (NIX_TX_OFFLOAD_MAX - 1)]

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#147: FILE: drivers/event/cnxk/cn20k_eventdev.c:260:
+#define T(name, sz, flags) [flags] = cn20k_sso_hws_tx_adptr_enq_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#153: FILE: drivers/event/cnxk/cn20k_eventdev.c:266:
+#define T(name, sz, flags) [flags] = cn20k_sso_hws_tx_adptr_enq_seg_##name,

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#215: FILE: drivers/event/cnxk/cn20k_tx_worker.h:35:
+		     "		ldxr %[val], [%[addr]]			
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#216: FILE: drivers/event/cnxk/cn20k_tx_worker.h:36:
+		     "		sub %[val], %[adj], %[val]		
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#217: FILE: drivers/event/cnxk/cn20k_tx_worker.h:37:
+		     "		lsl %[refill], %[val], %[shft]		
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#218: FILE: drivers/event/cnxk/cn20k_tx_worker.h:38:
+		     "		sub %[refill], %[refill], %[val]	
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#219: FILE: drivers/event/cnxk/cn20k_tx_worker.h:39:
+		     "		cmp %[refill], #0x0			
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#220: FILE: drivers/event/cnxk/cn20k_tx_worker.h:40:
+		     "		b.gt .Ldne%=				
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#221: FILE: drivers/event/cnxk/cn20k_tx_worker.h:41:
+		     "		sevl					
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#222: FILE: drivers/event/cnxk/cn20k_tx_worker.h:42:
+		     ".Lrty%=:	wfe					
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#223: FILE: drivers/event/cnxk/cn20k_tx_worker.h:43:
+		     "		ldxr %[val], [%[addr]]			
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#224: FILE: drivers/event/cnxk/cn20k_tx_worker.h:44:
+		     "		sub %[val], %[adj], %[val]		
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#225: FILE: drivers/event/cnxk/cn20k_tx_worker.h:45:
+		     "		lsl %[refill], %[val], %[shft]		
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#226: FILE: drivers/event/cnxk/cn20k_tx_worker.h:46:
+		     "		sub %[refill], %[refill], %[val]	
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#227: FILE: drivers/event/cnxk/cn20k_tx_worker.h:47:
+		     "		cmp %[refill], #0x0			
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#228: FILE: drivers/event/cnxk/cn20k_tx_worker.h:48:
+		     "		b.le .Lrty%=				
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#229: FILE: drivers/event/cnxk/cn20k_tx_worker.h:49:
+		     ".Ldne%=:						
"

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#337: FILE: drivers/event/cnxk/cn20k_tx_worker.h:157:
+#define T(name, sz, flags)                                                                         \
+	uint16_t __rte_hot cn20k_sso_hws_tx_adptr_enq_##name(void *port, struct rte_event ev[],    \
+							     uint16_t nb_events);                  \
+	uint16_t __rte_hot cn20k_sso_hws_tx_adptr_enq_seg_##name(                                  \
+		void *port, struct rte_event ev[], uint16_t nb_events);

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#346: FILE: drivers/event/cnxk/cn20k_tx_worker.h:166:
+#define SSO_TX(fn, sz, flags)                                                                      \
+	uint16_t __rte_hot fn(void *port, struct rte_event ev[], uint16_t nb_events)               \
+	{                                                                                          \
+		struct cn20k_sso_hws *ws = port;                                                   \
+		uint64_t cmd[sz];                                                                  \
+		RTE_SET_USED(nb_events);                                                           \
+		return cn20k_sso_hws_event_tx(ws, &ev[0], cmd,                                     \
+					      (const uint64_t *)ws->tx_adptr_data, flags);         \
+	}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#356: FILE: drivers/event/cnxk/cn20k_tx_worker.h:176:
+#define SSO_TX_SEG(fn, sz, flags)                                                                  \
+	uint16_t __rte_hot fn(void *port, struct rte_event ev[], uint16_t nb_events)               \
+	{                                                                                          \
+		uint64_t cmd[(sz) + CNXK_NIX_TX_MSEG_SG_DWORDS - 2];                               \
+		struct cn20k_sso_hws *ws = port;                                                   \
+		RTE_SET_USED(nb_events);                                                           \
+		return cn20k_sso_hws_event_tx(ws, &ev[0], cmd,                                     \
+					      (const uint64_t *)ws->tx_adptr_data,                 \
+					      (flags) | NIX_TX_MULTI_SEG_F);                       \
+	}

total: 3 errors, 18 warnings, 598 lines checked