|WARNING| pw146807 [PATCH v3 08/18] net/r8169: add support for phy configuration

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146807

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#119: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+	u8  HwSuppCheckPhyDisableModeVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#124: FILE: drivers/net/r8169/r8169_ethdev.h:47:
+	u32 HwSuppMaxPhyLinkSpeed;

CHECK:CAMELCASE: Avoid CamelCase: <PhyState>
#178: FILE: drivers/net/r8169/r8169_phy.c:375:
+rtl_wait_phy_ups_resume(struct rtl_hw *hw, u16 PhyState)

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#277: FILE: drivers/net/r8169/r8169_phy.c:474:
+		       ~(ADVERTISE_10HALF | ADVERTISE_10FULL | ADVERTISE_100HALF | ADVERTISE_100FULL));

CHECK:BRACES: braces {} should be used on all arms of this statement
#339: FILE: drivers/net/r8169/r8169_phy.c:536:
+	if (hw->hw_ram_code_ver == hw->sw_ram_code_ver) {
[...]
+	} else
[...]

CHECK:CAMELCASE: Avoid CamelCase: <HwHasWrRamCodeToMicroP>
#341: FILE: drivers/net/r8169/r8169_phy.c:538:
+		hw->HwHasWrRamCodeToMicroP = TRUE;

CHECK:BRACES: Unbalanced braces around else statement
#342: FILE: drivers/net/r8169/r8169_phy.c:539:
+	} else

CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#388: FILE: drivers/net/r8169/r8169_phy.c:585:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone
#388: FILE: drivers/net/r8169/r8169_phy.c:585:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'?
#659: FILE: drivers/net/r8169/r8169_phy.h:86:
+#define ADVERTISE_PAUSE_ASYM	0x0800	/* Try for asymetric pause     */

total: 0 errors, 2 warnings, 8 checks, 600 lines checked