|WARNING| pw147170 [PATCH v4 06/18] net/r8169: add phy registers access routines

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147170

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <RegNum>
#95: FILE: drivers/net/r8169/r8169_phy.c:43:
+rtl_map_phy_ocp_addr(u16 PageNum, u8 RegNum)

CHECK:CAMELCASE: Avoid CamelCase: <RegAddr>
#124: FILE: drivers/net/r8169/r8169_phy.c:72:
+rtl_mdio_real_read_phy_ocp(struct rtl_hw *hw, u32 RegAddr)

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Addr_Reg_shift>
#130: FILE: drivers/net/r8169/r8169_phy.c:78:
+	data32 <<= OCPR_Addr_Reg_shift;

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Flag>
#136: FILE: drivers/net/r8169/r8169_phy.c:84:
+		if (RTL_R32(hw, PHYOCP) & OCPR_Flag)

CHECK:CAMELCASE: Avoid CamelCase: <OCPDR_Data_Mask>
#139: FILE: drivers/net/r8169/r8169_phy.c:87:
+	value = RTL_R32(hw, PHYOCP) & OCPDR_Data_Mask;

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Write>
#174: FILE: drivers/net/r8169/r8169_phy.c:122:
+	data32 |= OCPR_Write | value;

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Write>
#250: FILE: drivers/net/r8169/r8169_phy.c:198:
+	RTL_W32(hw, EPHYAR, EPHYAR_Write |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask_v2>
#251: FILE: drivers/net/r8169/r8169_phy.c:199:
+		(addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_shift>
#251: FILE: drivers/net/r8169/r8169_phy.c:199:
+		(addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Data_Mask>
#252: FILE: drivers/net/r8169/r8169_phy.c:200:
+		(value & EPHYAR_Data_Mask));

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Flag>
#258: FILE: drivers/net/r8169/r8169_phy.c:206:
+		if (!(RTL_R32(hw, EPHYAR) & EPHYAR_Flag))

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Read>
#271: FILE: drivers/net/r8169/r8169_phy.c:219:
+	RTL_W32(hw, EPHYAR, EPHYAR_Read | (addr & EPHYAR_Reg_Mask_v2) <<

total: 0 errors, 1 warnings, 12 checks, 251 lines checked