|WARNING| pw147172 [PATCH v4 08/18] net/r8169: add support for phy configuration

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Oct 25 05:41:45 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147172

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#120: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+	u8  HwSuppCheckPhyDisableModeVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#125: FILE: drivers/net/r8169/r8169_ethdev.h:47:
+	u32 HwSuppMaxPhyLinkSpeed;

CHECK:CAMELCASE: Avoid CamelCase: <PhyState>
#180: FILE: drivers/net/r8169/r8169_phy.c:375:
+rtl_wait_phy_ups_resume(struct rtl_hw *hw, u16 PhyState)

CHECK:CAMELCASE: Avoid CamelCase: <HwHasWrRamCodeToMicroP>
#344: FILE: drivers/net/r8169/r8169_phy.c:539:
+		hw->HwHasWrRamCodeToMicroP = TRUE;

CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#392: FILE: drivers/net/r8169/r8169_phy.c:587:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone
#392: FILE: drivers/net/r8169/r8169_phy.c:587:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'?
#662: FILE: drivers/net/r8169/r8169_phy.h:86:
+#define ADVERTISE_PAUSE_ASYM	0x0800	/* Try for asymetric pause     */

total: 0 errors, 1 warnings, 6 checks, 601 lines checked


More information about the test-report mailing list