|WARNING| pw147465 [PATCH v5 05/18] net/r8169: add support for hw config

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147465

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <InterFrameGap>
#241: FILE: drivers/net/r8169/r8169_base.h:510:
+#define InterFrameGap       0x03    /* 3 means InterFrameGap = the shortest one */

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#272: FILE: drivers/net/r8169/r8169_ethdev.h:20:
+	u8  HwSuppIntMitiVer;

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#275: FILE: drivers/net/r8169/r8169_ethdev.h:23:
+	u8 EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#278: FILE: drivers/net/r8169/r8169_ethdev.h:26:
+	u8 HwSuppDashVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#280: FILE: drivers/net/r8169/r8169_ethdev.h:28:
+	u8 HwSuppOcpChannelVer;

CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#281: FILE: drivers/net/r8169/r8169_ethdev.h:29:
+	u8 AllowAccessDashOcp;

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Addr_Align>
#308: FILE: drivers/net/r8169/r8169_hw.c:32:
+		val_shift = addr % ERIAR_Addr_Align;

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Read>
#311: FILE: drivers/net/r8169/r8169_hw.c:35:
+		eri_cmd = ERIAR_Read | transformed_base_address |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Type_shift>
#312: FILE: drivers/net/r8169/r8169_hw.c:36:
+			  type << ERIAR_Type_shift |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ByteEn>
#313: FILE: drivers/net/r8169/r8169_hw.c:37:
+			  ERIAR_ByteEn << ERIAR_ByteEn_shift |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ByteEn_shift>
#313: FILE: drivers/net/r8169/r8169_hw.c:37:
+			  ERIAR_ByteEn << ERIAR_ByteEn_shift |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Flag>
#327: FILE: drivers/net/r8169/r8169_hw.c:51:
+			if (RTL_R32(hw, ERIAR) & ERIAR_Flag)

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Write>
#389: FILE: drivers/net/r8169/r8169_hw.c:113:
+		eri_cmd = ERIAR_Write | transformed_base_address |

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#577: FILE: drivers/net/r8169/r8169_hw.c:371:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);

CHECK:CAMELCASE: Avoid CamelCase: <StopReq>
#577: FILE: drivers/net/r8169/r8169_hw.c:371:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#595: FILE: drivers/net/r8169/r8169_hw.c:389:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));

CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#595: FILE: drivers/net/r8169/r8169_hw.c:389:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));

CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#608: FILE: drivers/net/r8169/r8169_hw.c:402:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Txfifo_empty>
#608: FILE: drivers/net/r8169/r8169_hw.c:402:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Rxfifo_empty>
#608: FILE: drivers/net/r8169/r8169_hw.c:402:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <IntrMitigate>
#622: FILE: drivers/net/r8169/r8169_hw.c:416:
+			if ((RTL_R16(hw, IntrMitigate) & (BIT_0 | BIT_1 | BIT_8)) ==

CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#633: FILE: drivers/net/r8169/r8169_hw.c:427:
+	RTL_W32(hw, RxConfig, RTL_R32(hw, RxConfig) &

CHECK:CAMELCASE: Avoid CamelCase: <AcceptErr>
#634: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptRunt>
#634: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptBroadcast>
#634: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptMulticast>
#634: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptMyPhys>
#635: FILE: drivers/net/r8169/r8169_hw.c:429:
+		AcceptMyPhys | AcceptAllPhys));

CHECK:CAMELCASE: Avoid CamelCase: <AcceptAllPhys>
#635: FILE: drivers/net/r8169/r8169_hw.c:429:
+		AcceptMyPhys | AcceptAllPhys));

CHECK:CAMELCASE: Avoid CamelCase: <CmdReset>
#654: FILE: drivers/net/r8169/r8169_hw.c:448:
+	RTL_W8(hw, ChipCmd, CmdReset);

CHECK:CAMELCASE: Avoid CamelCase: <Cfg9346>
#667: FILE: drivers/net/r8169/r8169_hw.c:461:
+	RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock);

CHECK:CAMELCASE: Avoid CamelCase: <Cfg9346_Unlock>
#667: FILE: drivers/net/r8169/r8169_hw.c:461:
+	RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock);

CHECK:CAMELCASE: Avoid CamelCase: <Config2>
#693: FILE: drivers/net/r8169/r8169_hw.c:487:
+			RTL_W8(hw, Config2, RTL_R8(hw, Config2) | BIT_7);

CHECK:CAMELCASE: Avoid CamelCase: <Config5>
#694: FILE: drivers/net/r8169/r8169_hw.c:488:
+			RTL_W8(hw, Config5, RTL_R8(hw, Config5) | BIT_0);

CHECK:CAMELCASE: Avoid CamelCase: <RxCfgDMAShift>
#789: FILE: drivers/net/r8169/r8169_hw.c:583:
+	RTL_W32(hw, RxConfig, (RX_DMA_BURST_unlimited << RxCfgDMAShift));

CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#814: FILE: drivers/net/r8169/r8169_hw.c:608:
+	RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) |

CHECK:CAMELCASE: Avoid CamelCase: <TxDMAShift>
#814: FILE: drivers/net/r8169/r8169_hw.c:608:
+	RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) |

CHECK:CAMELCASE: Avoid CamelCase: <TxInterFrameGapShift>
#815: FILE: drivers/net/r8169/r8169_hw.c:609:
+		(InterFrameGap << TxInterFrameGapShift));

CHECK:CAMELCASE: Avoid CamelCase: <Config1>
#844: FILE: drivers/net/r8169/r8169_hw.c:638:
+		RTL_W8(hw, Config1, RTL_R8(hw, Config1) & ~0x10);

CHECK:CAMELCASE: Avoid CamelCase: <EnableRxDescV4_0>
#989: FILE: drivers/net/r8169/r8169_hw.c:783:
+			RTL_W8(hw, 0xd8, RTL_R8(hw, 0xd8) & ~EnableRxDescV4_0);

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1056: FILE: drivers/net/r8169/r8169_phy.c:6:
+#include <stdio.h>

total: 0 errors, 1 warnings, 39 checks, 987 lines checked