|WARNING| pw147472 [PATCH v5 12/18] net/r8169: implement Tx path

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Oct 28 08:37:57 CET 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147472

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <NextHwDesCloPtr0>
#112: FILE: drivers/net/r8169/r8169_ethdev.h:80:
+	u32 NextHwDesCloPtr0;

CHECK:CAMELCASE: Avoid CamelCase: <BeginHwDesCloPtr0>
#113: FILE: drivers/net/r8169/r8169_ethdev.h:81:
+	u32 BeginHwDesCloPtr0;

CHECK:SPACING: No space is necessary after a cast
#203: FILE: drivers/net/r8169/r8169_rxtx.c:79:
+	RTE_ATOMIC(uint32_t) tx_tail;

CHECK:CAMELCASE: Avoid CamelCase: <RingEnd>
#317: FILE: drivers/net/r8169/r8169_rxtx.c:901:
+	txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd);

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrLow>
#428: FILE: drivers/net/r8169/r8169_rxtx.c:1012:
+	RTL_W32(hw, TxDescStartAddrLow,

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrHigh>
#430: FILE: drivers/net/r8169/r8169_rxtx.c:1014:
+	RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32));

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#444: FILE: drivers/net/r8169/r8169_rxtx.c:1028:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#444: FILE: drivers/net/r8169/r8169_rxtx.c:1028:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <TxVlanTag>
#457: FILE: drivers/net/r8169/r8169_rxtx.c:1039:
+	       (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) :

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv4>
#474: FILE: drivers/net/r8169/r8169_rxtx.c:1056:
+				opts[0] |= GiantSendv4;

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv6>
#476: FILE: drivers/net/r8169/r8169_rxtx.c:1058:
+				opts[0] |= GiantSendv6;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS_C>
#496: FILE: drivers/net/r8169/r8169_rxtx.c:1078:
+		csum_cmd |= TxIPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS_C>
#500: FILE: drivers/net/r8169/r8169_rxtx.c:1082:
+		csum_cmd |= TxUDPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS_C>
#503: FILE: drivers/net/r8169/r8169_rxtx.c:1085:
+		csum_cmd |= TxTCPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPV6F_C>
#510: FILE: drivers/net/r8169/r8169_rxtx.c:1092:
+			csum_cmd |= TxIPV6F_C;

CHECK:CAMELCASE: Avoid CamelCase: <DescOwn>
#603: FILE: drivers/net/r8169/r8169_rxtx.c:1185:
+	opts[0] = DescOwn;

CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag>
#635: FILE: drivers/net/r8169/r8169_rxtx.c:1217:
+			opts1 |= FirstFrag;

CHECK:CAMELCASE: Avoid CamelCase: <LastFrag>
#637: FILE: drivers/net/r8169/r8169_rxtx.c:1219:
+			opts1 |= LastFrag;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#675: FILE: drivers/net/r8169/r8169_rxtx.c:1257:
+	switch (hw->HwSuppTxNoCloseVer) {

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#701: FILE: drivers/net/r8169/r8169_rxtx.c:1283:
+	const uint8_t enable_tx_no_close = hw->EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#715: FILE: drivers/net/r8169/r8169_rxtx.c:1297:
+						   hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);

total: 0 errors, 0 warnings, 21 checks, 791 lines checked
Warning in drivers/net/r8169/r8169_rxtx.c:
Using rte_smp_[r/w]mb


More information about the test-report mailing list