|WARNING| pw152982 [PATCH 35/46] common/sfc_efx/base: support MAC statistics on Medford4 NICs

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/152982

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#222: FILE: drivers/common/sfc_efx/base/efx_np.c:1344:
+		sz = encp->enc_mac_stats_nstats * sizeof (efx_qword_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#258: FILE: drivers/common/sfc_efx/base/efx_np.c:1380:
+	return (rc);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#294: FILE: drivers/common/sfc_efx/base/medford4_impl.h:91:
+	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stats,

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#295: FILE: drivers/common/sfc_efx/base/medford4_impl.h:92:
+	__inout_opt			uint32_t *generationp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#319: FILE: drivers/common/sfc_efx/base/medford4_mac.c:128:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#323: FILE: drivers/common/sfc_efx/base/medford4_mac.c:132:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#339: FILE: drivers/common/sfc_efx/base/medford4_mac.c:148:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#343: FILE: drivers/common/sfc_efx/base/medford4_mac.c:152:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#370: FILE: drivers/common/sfc_efx/base/medford4_mac.c:179:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#374: FILE: drivers/common/sfc_efx/base/medford4_mac.c:183:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#378: FILE: drivers/common/sfc_efx/base/medford4_mac.c:187:
+	EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#384: FILE: drivers/common/sfc_efx/base/medford4_mac.c:193:
+	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stats,

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#385: FILE: drivers/common/sfc_efx/base/medford4_mac.c:194:
+	__inout_opt			uint32_t *generationp)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#396: FILE: drivers/common/sfc_efx/base/medford4_mac.c:205:
+	    (encp->enc_mac_stats_nstats * sizeof (efx_qword_t))) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#431: FILE: drivers/common/sfc_efx/base/medford4_mac.c:240:
+		    sizeof (generation_start)) != 0)

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#432: FILE: drivers/common/sfc_efx/base/medford4_mac.c:241:
+		return (EAGAIN);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#437: FILE: drivers/common/sfc_efx/base/medford4_mac.c:246:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#441: FILE: drivers/common/sfc_efx/base/medford4_mac.c:250:
+	return (rc);

total: 9 errors, 9 warnings, 329 lines checked