|WARNING| pw153117 [PATCH v2 34/45] common/sfc_efx/base: support MAC statistics on Medford4 NICs

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153117

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#203: FILE: drivers/common/sfc_efx/base/efx_np.c:1311:
+		sz = encp->enc_mac_stats_nstats * sizeof (efx_qword_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#239: FILE: drivers/common/sfc_efx/base/efx_np.c:1347:
+	return (rc);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#270: FILE: drivers/common/sfc_efx/base/medford4_impl.h:86:
+	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stats,

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#271: FILE: drivers/common/sfc_efx/base/medford4_impl.h:87:
+	__inout_opt			uint32_t *generationp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#297: FILE: drivers/common/sfc_efx/base/medford4_mac.c:136:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#301: FILE: drivers/common/sfc_efx/base/medford4_mac.c:140:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#328: FILE: drivers/common/sfc_efx/base/medford4_mac.c:167:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#332: FILE: drivers/common/sfc_efx/base/medford4_mac.c:171:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#336: FILE: drivers/common/sfc_efx/base/medford4_mac.c:175:
+	EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#342: FILE: drivers/common/sfc_efx/base/medford4_mac.c:181:
+	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stats,

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#343: FILE: drivers/common/sfc_efx/base/medford4_mac.c:182:
+	__inout_opt			uint32_t *generationp)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#353: FILE: drivers/common/sfc_efx/base/medford4_mac.c:192:
+	    (encp->enc_mac_stats_nstats * sizeof (efx_qword_t))) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#388: FILE: drivers/common/sfc_efx/base/medford4_mac.c:227:
+		    sizeof (generation_start)) != 0)

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#389: FILE: drivers/common/sfc_efx/base/medford4_mac.c:228:
+		return (EAGAIN);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#394: FILE: drivers/common/sfc_efx/base/medford4_mac.c:233:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#398: FILE: drivers/common/sfc_efx/base/medford4_mac.c:237:
+	return (rc);

total: 7 errors, 9 warnings, 292 lines checked