|WARNING| pw150810 [PATCH v2 01/54] net/e1000/base: copy i225 code into e1000

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150810

_coding style issues_


CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#137: FILE: drivers/net/intel/e1000/base/e1000_api.h:22:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);

WARNING:TYPO_SPELLING: 'Aserted' may be misspelled - perhaps 'Asserted'?
#208: FILE: drivers/net/intel/e1000/base/e1000_defines.h:640:
+#define E1000_ICS_DRSTA		E1000_ICR_DRSTA     /* Device Reset Aserted */

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#381: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1594:
+#define INVM_DWORD_TO_RECORD_TYPE(invm_dword) \
+	(u8)((invm_dword) & 0x7)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#383: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1596:
+#define INVM_DWORD_TO_WORD_ADDRESS(invm_dword) \
+	(u8)(((invm_dword) & 0x0000FE00) >> 9)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#385: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1598:
+#define INVM_DWORD_TO_WORD_DATA(invm_dword) \
+	(u16)(((invm_dword) & 0xFFFF0000) >> 16)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#820: FILE: drivers/net/intel/e1000/base/e1000_i225.c:203:
+	ret_val = e1000_disable_pcie_master_generic(hw);

total: 3 errors, 2 warnings, 1 checks, 2596 lines checked