|WARNING| pw149562 [PATCH v9 3/3] drivers/net: add diagnostics macros to make code portable

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/149562

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#227: FILE: drivers/net/fm10k/fm10k_rxtx_vec.c:473:
+__rte_diagnostic_pop

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#402: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:296:
+__rte_diagnostic_pop

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#722: FILE: drivers/net/i40e/i40e_rxtx_vec_sse.c:473:
+__rte_diagnostic_pop

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1101: FILE: drivers/net/iavf/iavf_rxtx_vec_sse.c:586:
+__rte_diagnostic_pop

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1136: FILE: drivers/net/iavf/iavf_rxtx_vec_sse.c:878:
+__rte_diagnostic_pop

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 0)
#1279: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:443:
 			if (rxq->vsi->adapter->pf.dev_data->dev_conf.rxmode.offloads &
[...]
+__rte_diagnostic_push

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 0)
#1351: FILE: drivers/net/ice/ice_rxtx_vec_avx512.c:473:
 			if (rxq->vsi->adapter->pf.dev_data->dev_conf.rxmode.offloads &
[...]
+__rte_diagnostic_push

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1450: FILE: drivers/net/ice/ice_rxtx_vec_sse.c:433:
+__rte_diagnostic_pop

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 0)
#1470: FILE: drivers/net/ice/ice_rxtx_vec_sse.c:497:
 		if (rxq->vsi->adapter->pf.dev_data->dev_conf.rxmode.offloads &
[...]
+__rte_diagnostic_push

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1637: FILE: drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:474:
+__rte_diagnostic_pop

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#1747: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.h:133:
+__rte_diagnostic_pop
 	for (pos = 0; pos < mcqe_n; ) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 0)
#1771: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.h:359:
 			if (!(pos & 0x7) && pos < mcqe_n) {
+__rte_diagnostic_push

total: 1 errors, 11 warnings, 0 checks, 1535 lines checked