|WARNING| pw155341 [PATCH v5 07/13] ethdev: add port mirroring feature

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jul 18 18:38:32 CEST 2025


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155341

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#154: FILE: lib/ethdev/ethdev_private.c:292:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#155: FILE: lib/ethdev/ethdev_private.c:293:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: exactly one space required after that #ifdef
#397: FILE: lib/ethdev/rte_ethdev.h:6706:
+#ifdef  RTE_ETHDEV_MIRROR

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#433: FILE: lib/ethdev/rte_ethdev_core.h:111:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#442: FILE: lib/ethdev/rte_ethdev_core.h:131:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#461: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

ERROR:SPACING: space prohibited after that open parenthesis '('
#570: FILE: lib/ethdev/rte_mirror.c:118:
+	while ( (mirror = *top) != NULL) {

total: 6 errors, 1 warnings, 730 lines checked


More information about the test-report mailing list