|WARNING| pw155571 [PATCH v7 07/12] ethdev: add port mirroring feature

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jul 29 00:09:56 CEST 2025


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155571

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#153: FILE: lib/ethdev/ethdev_private.c:292:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#154: FILE: lib/ethdev/ethdev_private.c:293:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#440: FILE: lib/ethdev/rte_ethdev_core.h:111:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#449: FILE: lib/ethdev/rte_ethdev_core.h:131:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#468: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#572: FILE: lib/ethdev/rte_mirror.c:113:
+ethdev_insert_mirror(RTE_ATOMIC(struct rte_eth_mirror *) *top,
                                                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#683: FILE: lib/ethdev/rte_mirror.c:224:
+ethdev_find_mirror(RTE_ATOMIC(struct rte_eth_mirror *) *head, uint16_t target_id)
                                                        ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#700: FILE: lib/ethdev/rte_mirror.c:241:
+ethdev_delete_mirror(RTE_ATOMIC(struct rte_eth_mirror *) *top, uint16_t target_id)
                                                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#829: FILE: lib/ethdev/rte_mirror.c:370:
+ethdev_mirror_stats_get(RTE_ATOMIC(struct rte_eth_mirror *) *head, uint16_t target_id,
                                                             ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#868: FILE: lib/ethdev/rte_mirror.c:409:
+ethdev_mirror_stats_reset(RTE_ATOMIC(struct rte_eth_mirror *) *head, uint16_t target_id)
                                                               ^

WARNING:TYPO_SPELLING: 'mirro' may be misspelled - perhaps 'mirror'?
#1019: FILE: lib/ethdev/rte_mirror.h:119:
+ *   A pointer to a structure of type *rte_eth_mirro_stats* to be filled.

total: 9 errors, 2 warnings, 859 lines checked


More information about the test-report mailing list