|WARNING| pw165158 [PATCH v7 1/1] net/mana: add device reset support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/165158

_coding style issues_


WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#457: FILE: drivers/net/mana/mana.c:955:
+ * Join the reset thread if it is active. Uses CAS on
                                                ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#465: FILE: drivers/net/mana/mana.c:963:
+	if (rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#479: FILE: drivers/net/mana/mana.c:977:
+ * Clear per-queue burst_state so the data path CAS can succeed again.
                                                 ^^^

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#892: FILE: drivers/net/mana/mana.c:1551:
+	 * Use CAS to avoid double-join if another path joined first.
 	       ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#899: FILE: drivers/net/mana/mana.c:1558:
+		if (rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1015: FILE: drivers/net/mana/mana.c:1674:
+	 * data path CAS can succeed again.
 	             ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1165: FILE: drivers/net/mana/mana.c:1817:
+					pthread_mutex_unlock(

CHECK:SPACING: No space is necessary after a cast
#1513: FILE: drivers/net/mana/mana.h:387:
+	RTE_ATOMIC(enum mana_device_state) dev_state;

CHECK:SPACING: No space is necessary after a cast
#1518: FILE: drivers/net/mana/mana.h:392:
+	RTE_ATOMIC(bool) reset_thread_active;

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1534: FILE: drivers/net/mana/mana.h:460:
+	 * Data path CAS 0→1 to enter; fails if any state bits are set.
 	             ^^^

CHECK:SPACING: No space is necessary after a cast
#1536: FILE: drivers/net/mana/mana.h:462:
+	RTE_ATOMIC(uint32_t) burst_state;

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1549: FILE: drivers/net/mana/mana.h:503:
+	 * Data path CAS 0→1 to enter; fails if any state bits are set.
 	             ^^^

CHECK:SPACING: No space is necessary after a cast
#1551: FILE: drivers/net/mana/mana.h:505:
+	RTE_ATOMIC(uint32_t) burst_state;

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1797: FILE: drivers/net/mana/rx.c:464:
+	/* Single atomic CAS: enter burst only if device is active (0→1).
 	                 ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1800: FILE: drivers/net/mana/rx.c:467:
+	if (unlikely(!rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1859: FILE: drivers/net/mana/tx.c:210:
+	/* Single atomic CAS: enter burst only if device is active (0→1).
 	                 ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1862: FILE: drivers/net/mana/tx.c:213:
+	if (unlikely(!rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1866: FILE: drivers/net/mana/tx.c:217:
+		if (!expected) /* CAS succeeded but db_page NULL — undo */
 		                  ^^^

total: 0 errors, 9 warnings, 9 checks, 1701 lines checked