|WARNING| net/iavf: reject oversized frames in prep callback

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/165219

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-10

# DPDK Patch Review

## Summary
This patch adds a packet length check to the iavf driver's transmit prepare callback to prevent oversized frames from triggering Malicious Driver Detection (MDD) on the PF. The change is minimal and focused.

---

## Errors

None identified.

---

## Warnings

### 1. Missing release notes update
**Issue:** The patch fixes a bug that could trigger MDD events on the PF, which is a significant behavioral fix, but does not update the release notes.

**Why it matters:** API changes, bug fixes affecting runtime behavior, and fixes for issues that could cause system problems should be documented in release notes so users know what has been fixed.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_26_07.rst` (or the appropriate current release notes file) under the "Fixed Issues" section:

```rst
* **net/iavf: Fixed oversized frame rejection**

  Added packet length validation in the transmit prepare callback to reject
  frames exceeding ``IAVF_FRAME_SIZE_MAX``. Previously, oversized non-TSO
  frames could trigger Malicious Driver Detection (MDD) on the PF.
```

---

## Info

### 1. Implicit comparison (style preference)
**Current code:**
```c
if (!(ol_flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG))) {
```

**DPDK style preference:** Explicit comparison against zero for integer values. However, bitwise operations in conditionals are common in DPDK and this pattern is widely used. This is a very minor style point and not worth changing given the patch is a targeted bug fix.

---

## Review Complete

The patch correctly addresses the stated bug by adding a packet length check alongside the existing segment count check. The logic is sound: non-TSO packets should be rejected if they exceed either the maximum segment count or the maximum frame size. The fix is minimal and does not introduce new correctness issues.

**Primary recommendation:** Add release notes entry (Warning-level issue).