|WARNING| pw165305 [PATCH 10/13] bus: implement cleanup in EAL

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/165305

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#640: FILE: lib/eal/include/bus_driver.h:433:
+#define RTE_REGISTER_BUS(nm, bus, bus_dev_type) \
 RTE_INIT_PRIO(businitfn_ ##nm, BUS) \
 {\
+	RTE_BUILD_BUG_ON(offsetof(typeof(bus_dev_type), device) != 0); \
 	(bus).name = RTE_STR(nm);\
 	rte_bus_register(&bus); \
 }

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

total: 1 errors, 0 warnings, 470 lines checked