|WARNING| [v1,1/1] net/i40e: allow discontiguous queue lists in hash

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/165461

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-15

# DPDK Patch Review

## Patch Summary
This patch fixes a regression in the i40e PMD where RSS queue lists were incorrectly required to be contiguous after a refactoring. The fix moves the `rss_queues_contig = true` setting to only apply to VLAN queue regions, restoring backwards compatibility.

---

## Correctness Issues

**No correctness bugs found.**

The patch correctly moves the contiguousness requirement to only the VLAN branch where queue *regions* are needed, while allowing non-contiguous queue *lists* in the general case. The logic flow is sound and matches the commit message description.

---

## C Coding Style

**No style violations found.**

The patch follows DPDK coding style:
- Indentation is consistent
- Comments use proper format
- Code structure matches surrounding context
- No forbidden tokens used

---

## API and Documentation

### Error: Missing Release Notes

**The patch fixes a backwards compatibility regression but does not update release notes.**

This is a bug fix that affects user-visible behavior (RSS queue configuration). Users upgrading from versions before the refactoring commit would encounter a functional change. The fix restores previous behavior and should be documented.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_07.rst` (or the appropriate current release file):

```rst
* **Fixed i40e RSS queue list handling.**

  Restored support for non-contiguous RSS queue lists in i40e PMD.
  Previously, all RSS configurations incorrectly required contiguous
  queue indices. Queue regions (VLAN path) still require contiguity.
```

### Warning: Missing Cc: stable

**The patch has a `Fixes:` tag referencing commit `0185303c2e24` but does not include `Cc: stable at dpdk.org`.**

Since this fixes a regression that breaks backwards compatibility, it should be backported to stable releases if the problematic refactor was included in an LTS release.

**Suggested fix:**
Add to commit message (after `Fixes:` line):
```
Cc: stable at dpdk.org
```

---

## Summary

**Errors (must fix):**
1. Missing release notes for user-visible bug fix

**Warnings (should fix):**
1. Missing `Cc: stable at dpdk.org` despite having `Fixes:` tag

The code changes themselves are correct and properly restore the intended behavior. The issues are process-related: documentation of the fix in release notes and ensuring backport to stable branches.