|WARNING| pw165528 [PATCH v10 1/1] net/mana: add device reset support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/165528

_coding style issues_


WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#478: FILE: drivers/net/mana/mana.c:955:
+ * Join the reset thread if it is active. Uses CAS on
                                                ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#489: FILE: drivers/net/mana/mana.c:966:
+	if (rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#514: FILE: drivers/net/mana/mana.c:991:
+ * Clear per-queue burst_state so the data path CAS can succeed again.
                                                 ^^^

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#954: FILE: drivers/net/mana/mana.c:1592:
+	 * Use CAS to avoid double-join if another path joined first.
 	       ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#961: FILE: drivers/net/mana/mana.c:1599:
+		if (rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1076: FILE: drivers/net/mana/mana.c:1714:
+	 * data path CAS can succeed again.
 	             ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1226: FILE: drivers/net/mana/mana.c:1857:
+					pthread_mutex_unlock(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1567: FILE: drivers/net/mana/mana.h:357:
+ *   Bit 0: in-burst (set by data path CAS 0→1, cleared on exit).
                                        ^^^

CHECK:SPACING: No space is necessary after a cast
#1579: FILE: drivers/net/mana/mana.h:393:
+	RTE_ATOMIC(enum mana_device_state) dev_state;

CHECK:SPACING: No space is necessary after a cast
#1584: FILE: drivers/net/mana/mana.h:398:
+	RTE_ATOMIC(bool) reset_thread_active;

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1600: FILE: drivers/net/mana/mana.h:466:
+	 * Data path CAS 0→1 to enter; fails if blocked bit is set.
 	             ^^^

CHECK:SPACING: No space is necessary after a cast
#1602: FILE: drivers/net/mana/mana.h:468:
+	RTE_ATOMIC(uint32_t) burst_state;

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1615: FILE: drivers/net/mana/mana.h:509:
+	 * Data path CAS 0→1 to enter; fails if blocked bit is set.
 	             ^^^

CHECK:SPACING: No space is necessary after a cast
#1617: FILE: drivers/net/mana/mana.h:511:
+	RTE_ATOMIC(uint32_t) burst_state;

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1866: FILE: drivers/net/mana/rx.c:464:
+	/* Single atomic CAS: enter burst only if device is active (0→1).
 	                 ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1869: FILE: drivers/net/mana/rx.c:467:
+	if (unlikely(!rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1928: FILE: drivers/net/mana/tx.c:210:
+	/* Single atomic CAS: enter burst only if device is active (0→1).
 	                 ^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1931: FILE: drivers/net/mana/tx.c:213:
+	if (unlikely(!rte_atomic_compare_exchange_strong_explicit(

WARNING:TYPO_SPELLING: 'CAS' may be misspelled - perhaps 'CASE'?
#1935: FILE: drivers/net/mana/tx.c:217:
+		if (!expected) /* CAS succeeded but db_page NULL — undo */
 		                  ^^^

total: 0 errors, 10 warnings, 9 checks, 1750 lines checked