|WARNING| net/iavf: report selected burst mode when no-poll active

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/165649

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-18

# DPDK Patch Review

## Summary
This patch fixes a bug where the Rx/Tx burst mode was incorrectly reported as "Disabled" when the no-poll wrapper was active, even though the wrapper was dispatching to a functional path. The fix changes the burst mode lookup from pointer comparison to directly indexing the path-info tables using the stored `rx_func_type`/`tx_func_type`.

## Findings

### Errors

None.

### Warnings

**1. Bounds check correctness**

Location: `iavf_rx_burst_mode_get()` and `iavf_tx_burst_mode_get()`

```c
if (rx_func_type >= RTE_DIM(iavf_rx_path_infos) ||
		iavf_rx_path_infos[rx_func_type].info == NULL)
	return -EINVAL;
```

The bounds check uses `>=` which is correct for array indexing. However, the second condition (`info == NULL`) suggests that some entries in the `iavf_rx_path_infos` array may have NULL info strings. This should be verified:

- If the path-info tables are fully populated at all indices from 0 to `RTE_DIM()-1`, the NULL check is defensive but acceptable
- If there are gaps (enum values that skip indices), this could hide a bug where `rx_func_type` is set to an invalid value that happens to pass the bounds check but has a NULL entry

**Recommendation:** Verify that `enum iavf_rx_func_type` and `enum iavf_tx_func_type` values are contiguous and match the array indices in `iavf_rx_path_infos[]` and `iavf_tx_path_infos[]`. If there are gaps, consider adding a more explicit enum-to-index mapping or asserting valid enum ranges.

**2. Missing validation of `rx_func_type`/`tx_func_type` at assignment time**

The patch assumes `adapter->rx_func_type` and `adapter->tx_func_type` are always valid enum values. If these fields can be set to out-of-range values elsewhere in the driver (e.g., during configuration or feature detection), the bounds check in this function becomes a runtime mitigation rather than a preventive measure.

**Recommendation:** Audit call sites that assign to `adapter->rx_func_type` and `adapter->tx_func_type` to ensure they validate the value or use a safe default. This is not a correctness bug in this patch itself, but a defensive programming concern for the overall driver.

### Info

**1. Improved code clarity**

The refactor from pointer comparison + loop search to direct array indexing is cleaner and more efficient. The new approach correctly addresses the original bug and simplifies the logic.

**2. Consistent error handling**

Both functions now consistently return `-EINVAL` for invalid paths, which is appropriate for an informational query operation.

---

## Conclusion

The patch correctly fixes the reported issue and improves code clarity. The bounds check is conservative but acceptable. No blocking issues found.

**Suggested verification (not blocking):**
- Confirm that `iavf_rx_path_infos[]` and `iavf_tx_path_infos[]` arrays are fully populated for all valid enum values
- Audit assignments to `adapter->rx_func_type` and `adapter->tx_func_type` to ensure they use valid enum values