|WARNING| [v2] net/iavf: report selected burst mode when no-poll active

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/165650

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-18

# DPDK Patch Review

## Patch Summary
This patch fixes burst mode reporting in the iavf PMD when the no-poll feature is active. It replaces function pointer comparison with direct indexing using the stored function type enum.

---

## Review Findings

### Errors

None identified.

### Warnings

None identified.

### Info

**1. Bounds check cast could use unsigned type directly**

The cast to `size_t` in the bounds check is functional, but the enum could be validated as non-negative first if there's any possibility of corruption, or the comparison could be rewritten to avoid the cast warning in a different way.

Current code:
```c
if ((size_t)rx_func_type >= RTE_DIM(iavf_rx_path_infos) ||
        iavf_rx_path_infos[rx_func_type].info == NULL)
    return -EINVAL;
```

This is acceptable as written. The cast silences the sign-compare warning and the NULL check provides defense-in-depth against out-of-bounds access if the enum is somehow corrupt. No change required.

**2. Identical pattern in Rx and Tx functions**

The Rx and Tx burst mode functions now have identical structure. This duplication is acceptable given that they operate on different types (`enum iavf_rx_func_type` vs `enum iavf_tx_func_type`) and different tables. Creating a shared helper would require type-erasing the enum and table types, likely making the code less clear.

---

## Positive Observations

1. **Correctness improvement**: The patch correctly fixes the reported issue where burst mode was always shown as "Disabled" when no-poll wrapper was active.

2. **Simplification**: Removes the loop-based function pointer search in favor of direct enum indexing, which is more efficient and less error-prone.

3. **Defense in depth**: The NULL check on `info` field guards against indexing an unpopulated entry in the path info table.

4. **Consistent pattern**: Both Rx and Tx functions updated identically, maintaining symmetry in the driver.

5. **No resource leaks or correctness bugs**: The change is purely a lookup optimization with no resource management changes.

---

## Compliance Summary

- **C coding style**: Compliant
- **Forbidden tokens**: None detected
- **API requirements**: Not applicable (internal PMD function)
- **Documentation**: Not required for internal PMD fix
- **Testing**: Fix is appropriate for stable backport (Cc: stable at dpdk.org present)
- **ABI/API impact**: None (internal PMD change only)

---

## Recommendation

**ACCEPT** - The patch correctly addresses the reported issue with no correctness, style, or process violations identified.