|WARNING| common/mlx5: add ConnectX-10 NVLink-C2C device ID

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/165902

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-22

# DPDK Patch Review

## Summary
This patch adds PCI device ID support for ConnectX-10 NVLink-C2C hardware to mlx5 drivers. The patch is straightforward and adds the new device ID constant and PCI ID table entries.

---

## Findings

### Errors
None found.

### Warnings

**1. Missing release notes update**

The patch adds support for new hardware (ConnectX-10 NVLink-C2C) but does not update the release notes. New driver hardware support should be documented in the current release notes file.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_XX_YY.rst` (where XX_YY is the current development release) under a "New Features" or "Drivers" section:

```rst
* **Updated mlx5 driver.**

  Added support for ConnectX-10 NVLink-C2C device (PCI ID 0x2101).
```

---

**2. Potential PMD features documentation update**

If the ConnectX-10 NVLink-C2C device has any feature differences from the standard ConnectX-10, the features matrix in `doc/guides/nics/features/mlx5.ini` may need updating. This is only a concern if the C2C variant has different capabilities (e.g., different offload support, link speeds, or flow control features).

**Suggested action:**
Verify whether the C2C variant has identical features to the base ConnectX-10. If features differ, update the features matrix accordingly.

---

### Info

**Device naming consistency**

The constant name `PCI_DEVICE_ID_MELLANOX_CONNECTX10C2C` uses "C2C" without a separator. Consider whether `PCI_DEVICE_ID_MELLANOX_CONNECTX10_C2C` (with underscore) would be more consistent with existing naming patterns, though the current choice is acceptable if it matches vendor documentation.

---

## Positive Observations

- The patch correctly adds the device ID to all three relevant locations (common header and both crypto/net driver PCI ID tables)
- PCI ID table entries follow the existing code structure
- The constant definition follows the established naming pattern for Mellanox device IDs
- No API changes, so no experimental/internal annotations needed
- No correctness issues identified (no resource leaks, no use-after-free, proper initialization)

---

## Conclusion

This is a clean hardware support addition. The only actionable item is adding the release notes entry documenting the new hardware support.