|WARNING| dev: skip multi-process in hotplug

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166217

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-25

# DPDK Patch Review

## Summary
This patch optimizes device hotplug operations by skipping multi-process messaging when multi-process support is disabled (`--no-shconf`/`--in-memory`).

---

## Errors

None identified.

---

## Warnings

### 1. Missing Release Notes

**Issue:** User-visible behavior change (performance optimization in single-process mode) is not documented in release notes.

**Why it matters:** Release notes inform users of improvements and help with troubleshooting.

**Suggested fix:** Add entry to `doc/guides/rel_notes/release_26_03.rst` (or current release):

```rst
* **Optimized single-process device hotplug.**

  When multi-process is disabled (``--no-shconf`` or ``--in-memory``),
  device probe and remove operations now skip building and sending
  multi-process messages, improving hotplug performance.
```

### 2. Boolean Variable Declaration Style

**Issue:** `do_mp` variable declared separately from first use in `rte_dev_probe()` and `rte_dev_remove()`.

**Suggested fix:** Prefer C99 style declaration at point of use for clarity:

```c
/* Current: */
const struct internal_config *internal_conf =
	eal_get_internal_configuration();
bool do_mp = internal_conf->no_shconf == 0;
struct eal_dev_mp_req req;
struct rte_device *dev;
int ret;

if (!do_mp)
	goto skip_mp_req;

/* Suggested: */
struct eal_dev_mp_req req;
struct rte_device *dev;
int ret;

const struct internal_config *internal_conf =
	eal_get_internal_configuration();
bool do_mp = internal_conf->no_shconf == 0;

if (!do_mp)
	goto skip_mp_req;
```

---

## Info

### 1. Code Quality Observations

**Positive aspects:**
- Consistent use of `bool` for the `do_mp` flag (good practice per guidelines)
- Explicit comparison `internal_conf->no_shconf == 0` (DPDK style compliant)
- Clean use of goto for skip logic in hotplug paths
- Error path rollback correctly conditioned on `do_mp`
- No resource leaks introduced (all early returns occur before allocations)

### 2. Alternative Approach

**Current pattern:**
```c
if (!do_mp)
	goto skip_mp_req;

/* multi-process code */

skip_mp_req:
/* continue */
```

**Alternative (early return style):**
Could use early function extraction for single-process case, but goto approach is acceptable given DPDK conventions and keeps error handling unified.

### 3. Testing Recommendation

**Suggested test coverage:**
- Verify hotplug with `--no-shconf` still functions correctly
- Verify hotplug with `--in-memory` still functions correctly
- Verify normal multi-process hotplug unchanged
- Benchmark showing performance improvement in single-process mode

---

## Conclusion

This patch is functionally correct with no errors identified. The primary improvement area is adding release notes to document the user-visible performance optimization. The code follows DPDK style guidelines and introduces no correctness issues.