|WARNING| net/e1000: align device IDs with base code

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166439

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-30

# DPDK Patch Review

## Patch Summary
This patch adds 70 missing PCI device IDs to the e1000 driver's probe table to align with device IDs defined in the base code header.

---

## Review Findings

### **Errors**

None found.

---

### **Warnings**

**1. Missing release notes update**

The patch adds support for 70 new PCI device IDs (new hardware support), which is a significant user-facing change. This requires an entry in the current release notes file under `doc/guides/rel_notes/release_26_07.rst` (or whatever the current release is).

**Suggested fix:**
Add a release notes entry similar to:
```rst
* **Updated e1000 PMD.**

  * Added support for 70 additional PCI device IDs from the base code,
    including older 82540/82541/82542/82543/82544/82545/82546/82547 series
    and additional ICH8/ICH9/ICH10/PCH variants.
```

---

**2. Missing functional verification statement**

Adding 70 device IDs without any mention of testing or verification raises the question: were these devices actually tested, or is this a mechanical sync from base code? The commit message should indicate whether these IDs were tested with actual hardware, tested in simulation/emulation, or are being added based on base code alignment alone.

**Suggested fix:**
Update the commit message to clarify the testing status, for example:
```
The e1000 base header lists multiple PCI device IDs in e1000_hw.h that
are not present in the em PCI ID table. Add the missing IDs so DPDK can
probe all e1000 devices defined by the shared base code.

Note: These device IDs are from the shared base code maintained by Intel.
While they have not been tested individually with DPDK (due to hardware
unavailability), they use the same driver code paths as existing supported
devices and are expected to work correctly.
```

---

### **Info**

**1. Consider grouping or commenting device ID additions**

The patch adds 70 device IDs in one contiguous block. Consider organizing them with comments to improve readability, grouping by chip family or generation. This would match the pattern often seen in other DPDK drivers.

Example structure:
```c
	/* PCH Platform Controller Hub variants */
	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH_PTP_I219_LM25) },
	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH_PTP_I219_V25) },
	...

	/* 80003ES2LAN series */
	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_80003ES2LAN_COPPER_DPT) },
	...

	/* 82540/82541 series */
	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_82540EM_LOM) },
	...
```

---

**2. Device ID constant verification**

While this review cannot verify that the constants used (e.g., `E1000_DEV_ID_PCH_PTP_I219_LM25`) actually exist in the base code header `e1000_hw.h`, this should be confirmed during testing/compilation. If any constant is undefined, compilation will fail, which is the correct behavior.

---

## Summary

**Must fix (Warnings):**
- Add release notes entry for new device ID support
- Clarify testing/verification status in commit message

**Consider (Info):**
- Add comments grouping device IDs by family for readability

The code changes themselves appear correct - this is a straightforward addition of PCI device ID entries to an existing probe table following the established pattern. No correctness bugs, style violations, or API issues were identified in the code changes.