|SUCCESS| [v2] crypto: update asym xform strings array

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Wed May 27 12:56:58 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164457

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-27

Commit: bd3745e29065 ("cryptodev: add PQC ML algorithms")
Author: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
Subject: [v2] crypto: update asym xform strings array

This patch updates the crypto_asym_xform_strings array to include
missing algorithm string mappings for asymmetric cryptographic
transforms.

> diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
> index 50071935c2..53210e52d6 100644
> --- a/lib/cryptodev/rte_cryptodev.c
> +++ b/lib/cryptodev/rte_cryptodev.c
> @@ -214,8 +214,13 @@ crypto_asym_xform_strings[] = {
>  	[RTE_CRYPTO_ASYM_XFORM_DH]	= "dh",
>  	[RTE_CRYPTO_ASYM_XFORM_DSA]	= "dsa",
>  	[RTE_CRYPTO_ASYM_XFORM_ECDSA]	= "ecdsa",
> +	[RTE_CRYPTO_ASYM_XFORM_ECDH]	= "ecdh",
>  	[RTE_CRYPTO_ASYM_XFORM_ECPM]	= "ecpm",
> +	[RTE_CRYPTO_ASYM_XFORM_ECFPM]	= "ecfpm",
> +	[RTE_CRYPTO_ASYM_XFORM_EDDSA]	= "eddsa",
>  	[RTE_CRYPTO_ASYM_XFORM_SM2]	= "sm2",
> +	[RTE_CRYPTO_ASYM_XFORM_ML_KEM]	= "ml-kem",
> +	[RTE_CRYPTO_ASYM_XFORM_ML_DSA]	= "ml-dsa",
>  };

Does this patch ensure that the array indices exactly match the enum
values defined for these transforms? If the enum defining these
RTE_CRYPTO_ASYM_XFORM_* constants has non-consecutive values or if
additional enums were added in between existing entries, could this
array become misaligned with the enum?

Are all the RTE_CRYPTO_ASYM_XFORM_* constants that are being added here
already defined in the appropriate header file? If these constants were
introduced in commit bd3745e29065 but the string mappings were missing,
has the enum definition been verified to match the array index order?


More information about the test-report mailing list