|SUCCESS| net/mlx5: promote private API to stable

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164489

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-27

git sha: 20260527103357.633429-1-dsosnowski at nvidia.com
Author: Dariusz Sosnowski <dsosnowski at nvidia.com>
Subject: [PATCH] net/mlx5: promote private API to stable

This patch promotes experimental mlx5 PMD driver event and steering
control APIs to stable status.

> diff --git a/drivers/net/mlx5/mlx5_driver_event.c b/drivers/net/mlx5/mlx5_driver_event.c
> index 1dc8029ee5..89e49331c8 100644
> --- a/drivers/net/mlx5/mlx5_driver_event.c
> +++ b/drivers/net/mlx5/mlx5_driver_event.c
> @@ -236,7 +236,7 @@ notify_existing_devices(rte_pmd_mlx5_driver_event_callback_t cb, void *opaque)
>  		notify_existing_queues(port_id, cb, opaque);
>  }
>  
> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pmd_mlx5_driver_event_cb_register, 25.11)
> +RTE_EXPORT_SYMBOL(rte_pmd_mlx5_driver_event_cb_register)

The symbol export macro change does not include a version number. Does
this code follow the requirements for stable symbol versioning? The
DPDK symbol versioning documentation requires explicit version tagging
for stable symbols in the version map file.

Have the corresponding changes been made to the version.map file to move
these symbols from the EXPERIMENTAL section to a versioned section?

> @@ -264,7 +264,7 @@ rte_pmd_mlx5_driver_event_cb_register(rte_pmd_mlx5_driver_event_callback_t cb, v
>  	return 0;
>  }
>  
> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pmd_mlx5_driver_event_cb_unregister, 25.11)
> +RTE_EXPORT_SYMBOL(rte_pmd_mlx5_driver_event_cb_unregister)

Same concern here - is the version map updated correctly for this symbol
promotion?

> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 915ea29a5a..a95dd9dc94 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -12506,7 +12506,7 @@ flow_disable_steering_run_on_related(struct rte_eth_dev *dev,
>  	}
>  }
>  
> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pmd_mlx5_disable_steering, 25.11)
> +RTE_EXPORT_SYMBOL(rte_pmd_mlx5_disable_steering)

Same versioning question applies to this steering control symbol.

> @@ -12532,7 +12532,7 @@ rte_pmd_mlx5_disable_steering(void)
>  	mlx5_steering_disabled = true;
>  }
>  
> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pmd_mlx5_enable_steering, 25.11)
> +RTE_EXPORT_SYMBOL(rte_pmd_mlx5_enable_steering)

And for this one as well - does the version map properly declare this as
a stable symbol with appropriate versioning?

> diff --git a/drivers/net/mlx5/rte_pmd_mlx5.h b/drivers/net/mlx5/rte_pmd_mlx5.h
> index 7acfdae97d..8f355070e1 100644
> --- a/drivers/net/mlx5/rte_pmd_mlx5.h
> +++ b/drivers/net/mlx5/rte_pmd_mlx5.h

[ ... ]

Per DPDK contribution guidelines, when promoting APIs from experimental
to stable status, the version.map file must be updated to move symbols
from the EXPERIMENTAL section to a properly versioned section (e.g.,
DPDK_26). Is this version map update included in the patch? The diff
shown does not include changes to any version.map file.