|SUCCESS| ethdev: promote flow metadata APIs to stable

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164488

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-27

Reviewing patch: ethdev: promote flow metadata APIs to stable

Git SHA: 20260527103246.633327-1-dsosnowski at nvidia.com
Author: Dariusz Sosnowski <dsosnowski at nvidia.com>

Subject: [PATCH] ethdev: promote flow metadata APIs to stable

This patch promotes experimental flow metadata APIs to stable status by
removing the experimental markers and updating the symbol versioning.
The APIs have been stable since v19.11 with only a type change in v20.05.

> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
> index 7a51b667cf..ec0fe08355 100644
> --- a/lib/ethdev/rte_flow.c
> +++ b/lib/ethdev/rte_flow.c
> @@ -23,11 +23,11 @@
>  #define FLOW_LOG RTE_ETHDEV_LOG_LINE
>  
>  /* Mbuf dynamic field name for metadata. */
> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_flow_dynf_metadata_offs, 19.11)
> +RTE_EXPORT_SYMBOL(rte_flow_dynf_metadata_offs)

Does the version file need to be updated? When promoting symbols from
experimental to stable, should the lib/ethdev/version.map file be
modified to move these symbols from the EXPERIMENTAL section to a
versioned section?

>  int32_t rte_flow_dynf_metadata_offs = -1;
>  
>  /* Mbuf dynamic field flag bit number for metadata. */
> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_flow_dynf_metadata_mask, 19.11)
> +RTE_EXPORT_SYMBOL(rte_flow_dynf_metadata_mask)
>  uint64_t rte_flow_dynf_metadata_mask;

Same question applies here for the version map file.

[ ... ]

> -RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_flow_dynf_metadata_register, 19.11)
> +RTE_EXPORT_SYMBOL(rte_flow_dynf_metadata_register)
>  int
>  rte_flow_dynf_metadata_register(void)
>  {

And here as well - does rte_flow_dynf_metadata_register need to be moved
in the version map?

> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index ba3bcc89a3..0c6d42c0d8 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -4253,14 +4253,12 @@ extern uint64_t rte_flow_dynf_metadata_mask;
>  #define RTE_MBUF_DYNFLAG_RX_METADATA (rte_flow_dynf_metadata_mask)
>  #define RTE_MBUF_DYNFLAG_TX_METADATA (rte_flow_dynf_metadata_mask)
>  
> -__rte_experimental
>  static inline uint32_t
>  rte_flow_dynf_metadata_get(struct rte_mbuf *m)
>  {
>  	return *RTE_FLOW_DYNF_METADATA(m);
>  }
>  
> -__rte_experimental
>  static inline void
>  rte_flow_dynf_metadata_set(struct rte_mbuf *m, uint32_t v)
>  {

[ ... ]

> @@ -4590,7 +4588,6 @@ rte_flow_dev_dump(uint16_t port_id, struct rte_flow *flow,
>   * @return
>   *   True if registered, false otherwise.
>   */
> -__rte_experimental
>  static inline int
>  rte_flow_dynf_metadata_avail(void)
>  {

[ ... ]

> @@ -4607,7 +4604,6 @@ rte_flow_dynf_metadata_avail(void)
>   * @return
>   *   0 on success, a negative errno value otherwise and rte_errno is set.
>   */
> -__rte_experimental
>  int
>  rte_flow_dynf_metadata_register(void);