|SUCCESS| [v6] mempool/dpaa: update for new mempool cache algorithm

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164493

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-27

Commit: [SHA to be determined from series.patch]
Author: Morten Brorup <mb at smartsharesystems.com>
Subject: mempool/dpaa: update for new mempool cache algorithm

This patch removes code that modifies the mempool cache's flushthresh
field, which has become obsolete due to an improved mempool cache
algorithm.

> diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
> index 2f9395b3f4..2f8555a026 100644
> --- a/drivers/mempool/dpaa/dpaa_mempool.c
> +++ b/drivers/mempool/dpaa/dpaa_mempool.c
> @@ -58,8 +58,6 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp)
>  	struct bman_pool_params params = {
>  		.flags = BMAN_POOL_FLAG_DYNAMIC_BPID
>  	};
> -	unsigned int lcore_id;
> -	struct rte_mempool_cache *cache;
>  
>  	MEMPOOL_INIT_FUNC_TRACE();

[ ... ]

> @@ -129,18 +127,6 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp)
>  	rte_memcpy(bp_info, (void *)&rte_dpaa_bpid_info[bpid],
>  		   sizeof(struct dpaa_bp_info));
>  	mp->pool_data = (void *)bp_info;
> -	/* Update per core mempool cache threshold to optimal value which is
> -	 * number of buffers that can be released to HW buffer pool in
> -	 * a single API call.
> -	 */
> -	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> -		cache = &mp->local_cache[lcore_id];
> -		DPAA_MEMPOOL_DEBUG("lCore %d: cache->flushthresh %d -> %d",
> -			lcore_id, cache->flushthresh,
> -			(uint32_t)(cache->size + DPAA_MBUF_MAX_ACQ_REL));
> -		if (cache->flushthresh)
> -			cache->flushthresh = cache->size + DPAA_MBUF_MAX_ACQ_REL;
> -	}

Does the removal of this cache tuning code affect correctness or
performance for the DPAA hardware? The original code adjusted
flushthresh based on DPAA_MBUF_MAX_ACQ_REL, which appears to be a
hardware-specific constraint. After this change, does the new mempool
cache algorithm automatically handle the hardware's batch size
requirements, or could this lead to suboptimal buffer release patterns?

If the dependency patch changes the mempool API such that flushthresh is
removed or made internal, should there be a corresponding update to verify
that the new algorithm respects the DPAA_MBUF_MAX_ACQ_REL limitation?

>  
>  	DPAA_MEMPOOL_INFO("BMAN pool created for bpid =%d", bpid);
>  	return 0;