<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi Ossama,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please see answers inline with [Arek]<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> ossama ahmed <ossamaahmedmughal@hotmail.com> <br>
<b>Sent:</b> Friday, April 1, 2022 1:18 PM<br>
<b>To:</b> users@dpdk.org<br>
<b>Subject:</b> Fw: OpenSSL Crypto Poll Mode Driver<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div id="Signature">
<div>
<p>Sent from <a href="http://aka.ms/weboutlook">Outlook</a><o:p></o:p></p>
</div>
</div>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> ossama ahmed<br>
<b>Sent:</b> Friday, April 1, 2022 11:10 AM<br>
<b>To:</b> <a href="mailto:users-request@dpdk.org">users-request@dpdk.org</a> <<a href="mailto:users-request@dpdk.org">users-request@dpdk.org</a>><br>
<b>Subject:</b> OpenSSL Crypto Poll Mode Driver</span> <o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal">Hello, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I would like to highlight following issues in OpenSSL Crypto Poll Mode Driver and OpenSSL vdev related to RSA Sign and Verify operations.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote>
<div>
<p class="MsoNormal"><u>ISSUES:</u><o:p></o:p></p>
</div>
<blockquote>
<div>
<p class="MsoNormal"><b>ISSUE1 (RSA_private_encrypt and RSA_public_decrypt)</b><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">With respect to <a href="https://www.openssl.org/docs/manmaster/man3/RSA_private_encrypt.html">
https://www.openssl.org/docs/manmaster/man3/RSA_private_encrypt.html</a> .Both of the functions are deprecated. Applications should instead use EVP_PKEY_sign_init_ex, EVP_PKEY_sign, EVP_PKEY_verify_recover_init, and EVP_PKEY_verify_recover.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Although I understand that due to compatibility reasons, DPDK is using native (in my case on Ubuntu 20.04.1 its 1.1.1f version of) OpenSSL but With respect<o:p></o:p></p>
<p class="MsoNormal">to OpenSSL's version 1.1.1f APIs "RSA_private_encrypt" and "RSA_public_decrypt" but in case of RSA_PKCS1_PADDING it is recomended that when generating or verifying<o:p></o:p></p>
<p class="MsoNormal">PKCS #1 signatures, RSA_sign(3) and RSA_verify(3) should be used.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>POSSIBLE SOLUTION</b><o:p></o:p></p>
<p class="MsoNormal">1. Use RSA_sign, RSA_verify, EVP_DigestSignFinal, EVP_DigestSign etc instead.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[Arek] – RSA_sign and RSA_verify are now deprecated too.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">2. Append algorithm identifier field to digest before signing. Details can be found in section EMSA-PKCS1-v1_5 availbel on
<a href="https://datatracker.ietf.org/doc/html/rfc8017#section-9.2">https://datatracker.ietf.org/doc/html/rfc8017#section-9.2</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">For example in case if RSA is using SHA256 for digest generation then DigestInfo value is:<o:p></o:p></p>
<p class="MsoNormal">SHA-256: (0x)30 31 30 0d 06 09 60 86 48 01 65 03 04 02 01 05 00 04 20 || H where H is the digest of data<o:p></o:p></p>
<p class="MsoNormal">Hence appropriate AIDs (i.e algorithm identifiers) must be appended to digest. Once this done then in case of RSA_PKCS1_PADDING, APIs RSA_private_encrypt and RSA_public_decrypt are compatible with RSA_sign, RSA_verify, EVP_DigestSignFinal,
EVP_DigestSign and verify respectively.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[Arek] – yes, you are perfectly correct, this Is general Cryptodev API problem. Proposals to fix that were sent already:<o:p></o:p></p>
<p class="MsoNormal"><a href="https://patchwork.dpdk.org/project/dpdk/list/?series=22203">https://patchwork.dpdk.org/project/dpdk/list/?series=22203</a>.
<o:p></o:p></p>
<p class="MsoNormal">When PKCS1 we should not worry about algorithmIdentifier from user perspective, although there was an option to do PKCS1 padding without it too (pre tls1.2 PKCS1.5 padding was used with 36 bytes hash concatenation for example), discussion
was started on dev mailing list. As for OpenSSL PMD simultaneously we are working to fix that.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>ISSUE2 (</b><b><span style="font-size:10.5pt;color:black;background:white">OpenSSL Crypto Poll Mode Driver vs RSA PSS Padding</span></b><b>)</b><o:p></o:p></p>
<div>
<p class="MsoNormal">Current DPDK's OpenSSL Crypto Poll Mode Driver fails to verify signature generated using RSA PSS Padding. Also with respect to latest version of DPDK there is no handling available in OpenSSL Crypto Poll Mode Driver for RTE_CRYPTO_RSA_PADDING_PSS.
Current implementation handles only RTE_CRYPTO_RSA_PADDING_NONE and<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">RTE_CRYPTO_RSA_PADDING_PKCS1_5 for signing and verification.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[Arek] – yes, PSS should be implemented too. Registration of openssl random engine should allow us to check known answer tests too not only PWCT, could you resend your proposal to dev list?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">1. EVP_DigestSignFinal, EVP_DigestSign etc instead.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">2. As coded in OpenSSL (crypto/rsa/rsa_pmeth.c +268):<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">else if (rctx->pad_mode == RSA_PKCS1_PSS_PADDING) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> int ret;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> if (!setup_tbuf(rctx, ctx))<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> return -1;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> ret = RSA_public_decrypt(siglen, sig, rctx->tbuf, rsa, RSA_NO_PADDING);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> if (ret <= 0)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> return 0;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> ret = RSA_verify_PKCS1_PSS_mgf1(rsa, tbs, rctx->md, rctx->mgf1md, rctx->tbuf, rctx->saltlen);<o:p></o:p></p>
<p class="MsoNormal">[Arek] – whole openssl low level api is deprecated now, these functions as well so we wont be using it.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> if (ret <= 0)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> return 0;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> return 1;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> }<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">However, in order to use above implementation changes are required in OpenSSL Crypto Poll Mode Driver (drivers/crypto/openssl/rte_openssl_pmd.c +1945) for example<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"> case RTE_CRYPTO_ASYM_OP_VERIFY:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> tmp = rte_malloc(NULL, op->rsa.sign.length, 0);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> if (tmp == NULL) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> OPENSSL_LOG(ERR, "Memory allocation failed");<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> cop->status = RTE_CRYPTO_OP_STATUS_ERROR;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> break;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> }<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> ret = RSA_public_decrypt(op->rsa.sign.length,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> op->rsa.sign.data,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> tmp,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> rsa,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> pad);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"> OPENSSL_LOG(DEBUG,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> "Length of public_decrypt %d "<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> "length of message %zd\n",<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> ret, op->rsa.message.length);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> //FIXME<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> if(pad == RSA_NO_PADDING && ret) <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> memcpy(op->rsa.message.data, tmp, op->rsa.sign.length);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> else if ((ret <= 0) || (CRYPTO_memcmp(tmp, op->rsa.message.data,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> op->rsa.message.length))) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> OPENSSL_LOG(ERR, "RSA sign Verification failed");<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> cop->status = RTE_CRYPTO_OP_STATUS_ERROR;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> }<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> //FIXME<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> rte_free(tmp);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> break;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> Complete details are availble in section 8.1.2 of
<a href="https://datatracker.ietf.org/doc/html/rfc8017#section-8.1.2">https://datatracker.ietf.org/doc/html/rfc8017#section-8.1.2</a><o:p></o:p></p>
</div>
</blockquote>
</blockquote>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">I have handled the above mentioned issues in DPDK using my own custom implementation. I would love to share details if required for further clarification<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Regards,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Ossama Ahmed Mughal<o:p></o:p></span></p>
</div>
<div>
<div id="x_Signature">
<div>
<p><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>