<div dir="ltr">Thanks for the info,<div>I have a question, is there any hard limit on how many supports can be configured on port?</div><div>The default seems to be 8. <div> LevelSiblings per ParentFunctional Description1Port<ul class="gmail-first gmail-last gmail-simple" style="box-sizing:border-box;margin:0px;padding:0px;list-style-position:initial;line-height:24px"><li style="box-sizing:border-box;list-style:disc;margin-left:24px;margin-bottom:0px"></li></ul><ol class="gmail-first gmail-last gmail-arabic gmail-simple" style="box-sizing:border-box;margin:0px;padding:0px;list-style-position:initial;line-height:24px"><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">Output Ethernet port 1/10/40 GbE.</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px;margin-bottom:0px">Multiple ports are scheduled in round robin order with all ports having equal priority.</li></ol>2SubportConfigurable (default: 8)<ol class="gmail-first gmail-last gmail-arabic gmail-simple" style="box-sizing:border-box;margin:0px;padding:0px;list-style-position:initial;line-height:24px"><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">Traffic shaping using token bucket algorithm (one token bucket per subport).</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">Upper limit enforced per Traffic Class (TC) at the subport level.</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px;margin-bottom:0px">Lower priority TCs able to reuse subport bandwidth currently unused by higher priority TCs.</li></ol>3PipeConfigurable (default: 4K)<ol class="gmail-first gmail-last gmail-arabic gmail-simple" style="box-sizing:border-box;margin:0px;padding:0px;list-style-position:initial;line-height:24px"><li style="box-sizing:border-box;list-style:decimal;margin-left:24px;margin-bottom:0px">Traffic shaping using the token bucket algorithm (one token bucket per pipe.</li></ol>4Traffic Class (TC)13<ol class="gmail-first gmail-last gmail-arabic gmail-simple" style="box-sizing:border-box;margin:0px;padding:0px;list-style-position:initial;line-height:24px"><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">TCs of the same pipe handled in strict priority order.</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">Upper limit enforced per TC at the pipe level.</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">Lower priority TCs able to reuse pipe bandwidth currently unused by higher priority TCs.</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px;margin-bottom:0px">When subport TC is oversubscribed (configuration time event), pipe TC upper limit is capped to a dynamically adjusted value that is shared by all the subport pipes.</li></ol>5QueueHigh priority TCs: 1, Lowest priority TC: 4<ol class="gmail-first gmail-last gmail-arabic gmail-simple" style="box-sizing:border-box;margin:0px;padding:0px;list-style-position:initial;line-height:24px"><li style="box-sizing:border-box;list-style:decimal;margin-left:24px">All the high priority TCs (TC0, TC1, …,TC11) have exactly 1 queue, while the lowest priority TC (TC12), called Best Effort (BE), has 4 queues.</li><li style="box-sizing:border-box;list-style:decimal;margin-left:24px;margin-bottom:0px">Queues of the lowest priority TC (BE) are serviced using Weighted Round Robin (WRR) according to predefined weights weights.</li></ol></div></div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 7, 2022 at 1:29 PM Singh, Jasvinder <<a href="mailto:jasvinder.singh@intel.com">jasvinder.singh@intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div lang="EN-IE" style="overflow-wrap: break-word;"> <div class="gmail-m_92939016544878645WordSection1"> Hi Satish, I would encourage you to have a look at library code especially around dequeue operation to understand the scheduling behaviour. Some of the answers are inline; Thanks, Jasvinder <div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0cm 0cm 0cm 4pt"> <div> <div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm"> From: satish amara <<a href="mailto:satishkamara@gmail.com" target="_blank">satishkamara@gmail.com</a>> Sent: Wednesday, April 6, 2022 7:06 PM To: Singh, Jasvinder <<a href="mailto:jasvinder.singh@intel.com" target="_blank">jasvinder.singh@intel.com</a>> Cc: Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>>; <a href="mailto:users@dpdk.org" target="_blank">users@dpdk.org</a>; Dumitrescu, Cristian <<a href="mailto:cristian.dumitrescu@intel.com" target="_blank">cristian.dumitrescu@intel.com</a>> Subject: Re: Fwd: QOS sample example. </div> </div> <div> Thank you. I have a question about how the active Traffic class is selected in a pipe. <div> Let's say I have confugured only one Subport and one Pipe on interface. </div> <div> <div> If the highest priority traffic class in a pipe has exhausted it's rate limit can lower traffic class in the same pipe be dequeued. Yes.once highest priority TC has consumed its allocated credits, and at the pipe level, there are credits available, then packets from next priority tc will be scheduled. </div> <div> Can I have profile for Pipe where bandwidth for Pipe is shared among multiple TC's </div> <div> Here is an example how I want to configure pipe so bandwidth allocated to Pipe is shared among 13 classes giving priority to highest queue provided it didn't exceed the rate limit. </div> <div> </div> <div> <div> pipe_profile 0 { </div> <div> tb_rate 1300000 /* Pipe level token bucket rate (bytes per second) */ </div> <div> tb_size 1000000 /* Pipe level token bucket size (bytes) */ </div> <div> tc0_rate 100000 /* Pipe level token bucket rate for traffic class 0 (bytes per second) */ </div> <div> tc1_rate 100000 /* Pipe level token bucket rate for traffic class 1 (bytes per second) */ </div> <div> tc2_rate 100000 /* Pipe level token bucket rate for traffic class 2 (bytes per second) */ </div> <div> tc3_rate 100000 </div> <div> ..... /* Pipe level token bucket rate for traffic class 3 (bytes per second) */ </div> <div> tc13_rate 100000 </div> <div> tc_period 40 /* Time int </div> </div> <div> } DPDK QoS sample app has such profile defined if that helps. </div> <div> The scheduling decision to send next packet from (subport S, pipe P, traffic class TC, queue Q) is favorable (packet is sent) when all the conditions below are met: · Pipe P of subport S is currently selected by one of the port grinders; · Traffic class TC is the highest priority active traffic class of pipe P; · Queue Q is the next queue selected by WRR within traffic class TC of pipe P; · Subport S has enough credits to send the packet; · Subport S has enough credits for traffic class TC to send the packet; · Pipe P has enough credits to send the packet; · Pipe P has enough credits for traffic class TC to send the packet. If all the above conditions are met, then the packet is selected for transmission and the necessary credits are subtracted from subport S, subport S traffic class TC, pipe P, pipe P traffic class TC. Yes, have a look at the grinder_credits_check () function in the library code. <div> </div> </div> </div> </div> <div> <div> On Wed, Apr 6, 2022 at 12:34 PM Singh, Jasvinder <<a href="mailto:jasvinder.singh@intel.com" target="_blank">jasvinder.singh@intel.com</a>> wrote: </div> <blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"> <div> <div> Yes, it is fixed. The tc_credits_per_period is updated after tc_period duration. Note that tc credits don’t get accumulated if tc queue is visited after multiple tc_period due to rate limiting mechanism at the traffic class level. <div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0cm 0cm 0cm 4pt"> <div> <div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm"> From: satish amara <<a href="mailto:satishkamara@gmail.com" target="_blank">satishkamara@gmail.com</a>> Sent: Wednesday, April 6, 2022 4:32 PM To: Singh, Jasvinder <<a href="mailto:jasvinder.singh@intel.com" target="_blank">jasvinder.singh@intel.com</a>> Cc: Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>>; <a href="mailto:users@dpdk.org" target="_blank">users@dpdk.org</a>; Dumitrescu, Cristian <<a href="mailto:cristian.dumitrescu@intel.com" target="_blank">cristian.dumitrescu@intel.com</a>> Subject: Re: Fwd: QOS sample example. </div> </div> <div> Jasvinder, <div> I have a few more questions. </div> <div> Can you provide some clarity on </div> <table border="0" cellspacing="0" cellpadding="0" style="background:rgb(252,252,252);border-collapse:collapse;border-spacing:0px;empty-cells:show" id="gmail-m_92939016544878645gmail-m_-7260357973067368546gmail-id23"> <tbody> <tr style="box-sizing:border-box"> <td nowrap style="border-style:inset inset solid solid;border-left-color:rgb(225,228,229);border-bottom-color:rgb(225,228,229);border-width:1pt;background:rgb(243,246,246);padding:6pt 12pt;border-top-color:initial;border-right-color:initial;box-sizing:border-box;overflow:visible"> tc_credits_per_period </td> </tr> </tbody> </table> tc_period is for how often the credits for traffic need to be updated. Is tc_credits_per_period is fixed based on tc_rate. <div> </div> <div> Regards, </div> <div> Satish Amara </div> </div> <div> <div> On Fri, Apr 1, 2022 at 9:34 AM satish amara <<a href="mailto:satishkamara@gmail.com" target="_blank">satishkamara@gmail.com</a>> wrote: </div> <blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin:5pt 0cm 5pt 4.8pt"> <div> Thanks for the info Jasvinder. I see there is an internal timer to see when to refill the token buckets and credits. I have read the QOS document. My understanding is that the DPDK code is using the same HQOS thread CPU context to implement timer functionality during the pipe selection and not leveraging on Linux timers or other timers. <div> </div> <div> Regards, </div> <div> Satish Amara </div> </div> <div> <div> On Fri, Apr 1, 2022 at 4:36 AM Singh, Jasvinder <<a href="mailto:jasvinder.singh@intel.com" target="_blank">jasvinder.singh@intel.com</a>> wrote: </div> <blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin:5pt 0cm 5pt 4.8pt"> <div> <div> Hi Satish, DPDK HQoS scheduler has internal timer to compute the credits. The time difference between the two consecutive visit to the same pipe is used to compute the number of tb_periods elapsed and based on that, the available credits in the token bucket is computed. Each pipe has its own context which stores the timestamp of the last visit and it is used when pipe is visited to schedule the packets from its queues. Thanks, Jasvinder <div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0cm 0cm 0cm 4pt"> <div> <div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm"> From: satish amara <<a href="mailto:satishkamara@gmail.com" target="_blank">satishkamara@gmail.com</a>> Sent: Thursday, March 31, 2022 9:27 PM To: Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>> Cc: <a href="mailto:users@dpdk.org" target="_blank">users@dpdk.org</a>; Singh, Jasvinder <<a href="mailto:jasvinder.singh@intel.com" target="_blank">jasvinder.singh@intel.com</a>>; Dumitrescu, Cristian <<a href="mailto:cristian.dumitrescu@intel.com" target="_blank">cristian.dumitrescu@intel.com</a>> Subject: Re: Fwd: QOS sample example. </div> </div> <div> Thanks, Thomas for forwarding this to the group. <div> <div> I have one more question. Does DPDK QOS uses any internal threads/timers for the token bucket implementation?. The token </div> <div> buckets can be implemented in different ways. When are the tokens are filled, I see there is tb_period? </div> <div> It looks like the tokens are filled when the HQOS thread is trying to find the next active pipe? </div> <div> </div> <div> Regards, </div> <div> Satish Amara </div> <div> </div> <div> </div> </div> </div> <div> <div> On Thu, Mar 31, 2022 at 3:39 PM Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>> wrote: </div> <blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin:5pt 0cm 5pt 4.8pt"> +Cc QoS scheduler maintainers (see file MAINTAINERS) 31/03/2022 18:59, satish amara: > Hi, > I am trying to understand the QOS sample scheduler application code. > Trying to understand what is tc_period in the config. > 30. QoS Scheduler Sample Application — Data Plane Development Kit 21.05.0 > documentation (<a href="http://dpdk.org" target="_blank">dpdk.org</a>) > <<a href="https://doc.dpdk.org/guides-21.05/sample_app_ug/qos_scheduler.html" target="_blank">https://doc.dpdk.org/guides-21.05/sample_app_ug/qos_scheduler.html</a>> Is > tc_period same as tb_period > tb_period Bytes Time period that should elapse since the last credit update > in order for the bucket to be awarded tb_credits_per_period worth or > credits. > Regards, > Satish Amara > </blockquote> </div> </div> </div> </div> </blockquote> </div> </blockquote> </div> </div> </div> </div> </blockquote> </div> </div> </div> </div> </blockquote></div>