<div dir="ltr"><div dir="ltr">Thanks for clarifying the question regarding Txd size Stephen.<div>I tested out the RSS for TCP UDP.</div><div>As suggested , I set the TCP flags alone in RSS conf and configured the netvsc port.</div><div><br></div><div><div style="color:rgb(51,51,51);background-color:rgb(245,245,245);font-family:Menlo,Monaco,"Courier New",monospace;font-size:12px;line-height:18px;white-space:pre-wrap"><div> <span style="color:rgb(122,62,157)">struct</span> rte_eth_conf conf <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">{</span></div><div> .intr_conf <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">{</span></div><div> .lsc <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">!</span><span style="color:rgb(122,62,157)">dpdk</span><span style="color:rgb(119,119,119)">.</span><span style="color:rgb(122,62,157)">lsc_intr_disable</span> <span style="color:rgb(119,119,119)">&&</span> <span style="color:rgb(119,119,119)">!</span><span style="color:rgb(122,62,157)">dpdk_if</span><span style="color:rgb(119,119,119)">-></span><span style="color:rgb(122,62,157)">lsc_intr_disable</span> <span style="color:rgb(119,119,119)">&&</span></div><div> <span style="color:rgb(119,119,119)">!!(</span><span style="color:rgb(122,62,157)">dev</span><span style="color:rgb(119,119,119)">-></span><span style="color:rgb(122,62,157)">data</span><span style="color:rgb(119,119,119)">-></span><span style="color:rgb(122,62,157)">dev_flags</span> <span style="color:rgb(119,119,119)">&</span> RTE_ETH_DEV_INTR_LSC<span style="color:rgb(119,119,119)">),</span></div><div> <span style="color:rgb(119,119,119)">},</span></div><div> .rxmode <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">{</span></div><div> .mq_mode <span style="color:rgb(119,119,119)">=</span> RTE_ETH_MQ_RX_RSS<span style="color:rgb(119,119,119)">,</span></div><div> .offloads <span style="color:rgb(119,119,119)">=</span> RTE_ETH_RX_OFFLOAD_VLAN_STRIP <span style="color:rgb(119,119,119)">|</span> RTE_ETH_RX_OFFLOAD_IPV4_CKSUM <span style="color:rgb(119,119,119)">|</span></div><div> RTE_ETH_RX_OFFLOAD_RSS_HASH <span style="color:rgb(119,119,119)">|</span> RTE_ETH_RX_OFFLOAD_UDP_CKSUM<span style="color:rgb(119,119,119)">,</span></div><div> <span style="color:rgb(119,119,119)">},</span></div><div> .<span style="color:rgb(122,62,157)">rx_adv_conf</span><span style="color:rgb(119,119,119)">.</span><span style="color:rgb(122,62,157)">rss_conf</span> <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">{</span></div><div> .rss_hf <span style="color:rgb(119,119,119)">=</span> RTE_ETH_RSS_NONFRAG_IPV4_TCP <span style="color:rgb(119,119,119)">|</span> RTE_ETH_RSS_NONFRAG_IPV6_TCP<span style="color:rgb(119,119,119)">,</span><br></div><div> .rss_key <span style="color:rgb(119,119,119)">=</span> conf_rss_key<span style="color:rgb(119,119,119)">,</span></div><div> .rss_key_len <span style="color:rgb(119,119,119)">=</span> rss_key_len<span style="color:rgb(119,119,119)">,</span></div><div> <span style="color:rgb(119,119,119)">},</span></div><div> .txmode <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">{</span></div><div> .offloads <span style="color:rgb(119,119,119)">=</span> RTE_ETH_TX_OFFLOAD_UDP_CKSUM <span style="color:rgb(119,119,119)">|</span> RTE_ETH_TX_OFFLOAD_IPV4_CKSUM<span style="color:rgb(119,119,119)">,</span></div><div> <span style="color:rgb(119,119,119)">},</span></div><div> <span style="color:rgb(119,119,119)">};</span></div></div></div><div><div style="background-color:rgb(245,245,245);font-family:Menlo,Monaco,"Courier New",monospace;font-size:12px;line-height:18px;white-space:pre-wrap"><div><font color="#333333"> </font><span style="color:rgb(170,55,49);font-weight:bold">rte_eth_dev_configure</span><span style="color:rgb(119,119,119)">(</span><font color="#7a3e9d"><netvsc port></font><span style="color:rgb(119,119,119)">,</span><font color="#333333"> </font><span style="color:rgb(122,62,157)">num_rxq</span><span style="color:rgb(119,119,119)">,</span><span style="color:rgb(122,62,157)">num_txq</span><span style="color:rgb(119,119,119)">,</span><font color="#333333"> </font><span style="color:rgb(119,119,119)">&</span><font color="#333333">conf</font><span style="color:rgb(119,119,119)">);
</span><div style="line-height:18px"><div style="color:rgb(51,51,51)"> <span style="color:rgb(122,62,157)">uint8_t</span> <span style="color:rgb(122,62,157)">rss_key_temp</span><span style="color:rgb(119,119,119)">[</span><span style="color:rgb(156,93,39)">64</span><span style="color:rgb(119,119,119)">];</span></div><div style="color:rgb(51,51,51)"> <span style="color:rgb(122,62,157)">struct</span> rte_eth_rss_conf rss_conf <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">{</span></div><div style="color:rgb(51,51,51)"> .rss_key <span style="color:rgb(119,119,119)">=</span> rss_key_temp<span style="color:rgb(119,119,119)">,</span></div><div style="color:rgb(51,51,51)"> .rss_key_len <span style="color:rgb(119,119,119)">=</span> <span style="color:rgb(119,119,119)">sizeof(</span>rss_key_temp<span style="color:rgb(119,119,119)">),</span></div><div style="color:rgb(51,51,51)"> <span style="color:rgb(119,119,119)">};</span></div><div><font color="#333333"> ret </font><span style="color:rgb(119,119,119)">=</span><font color="#333333"> </font><span style="color:rgb(170,55,49);font-weight:bold">rte_eth_dev_rss_hash_conf_get</span><span style="color:rgb(119,119,119)">(</span><font color="#7a3e9d"><VF port></font><span style="color:rgb(119,119,119)">,</span><font color="#333333"> </font><span style="color:rgb(119,119,119)">&</span><font color="#333333">rss_conf</font><span style="color:rgb(119,119,119)">);</span></div><div style="color:rgb(51,51,51)"><br></div></div></div></div></div></div><br><div class="gmail_quote"><div class="gmail_attr">Now the VF port RSS offloads show only TCP flags set and not UDP. I assumed that even the UDP flags might be set. Is this expected ?</div><div class="gmail_attr"><br></div><div class="gmail_attr">Regards,</div><div class="gmail_attr">Nandini </div><div dir="ltr" class="gmail_attr"><br></div><div dir="ltr" class="gmail_attr"><br></div><div dir="ltr" class="gmail_attr">On Thu, Sep 12, 2024 at 4:09 PM Stephen Hemminger <<a href="mailto:stephen@networkplumber.org" target="_blank">stephen@networkplumber.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 12 Sep 2024 13:47:37 -0700<br>
Nandini Rangaswamy <<a href="mailto:nandini.rangaswamy@broadcom.com" target="_blank">nandini.rangaswamy@broadcom.com</a>> wrote:<br>
<br>
> Thanks for your response Long Li.<br>
> I see with netvsc the maximum number of Tx descriptors is restricted to<br>
> 4096 whereas the number of Rx descriptors is restricted to 8192.<br>
> But, for failsafe PMD , we see that both the number of Txd and Rxd is<br>
> restricted to 8192.<br>
> How is netvsc PMD giving the same performance as failsafe PMD ?<br>
> <br>
> Regards<br>
<br>
I think the limits there were somewhat arbitrary chose with netvsc.<br>
Don't remember a hard reason that would block larger sizes.<br>
<br>
<br>
Having really big rings won't help performance (i.e BufferBloat) and<br>
could a lot of memory consumption. When all heavy data traffic goes through<br>
the VF and that ring is different. Only DoS attacks should be impacted<br>
by rx/tx descriptor limits in the netvsc device. The linux driver actually<br>
has much smaller buffer.<br>
</blockquote></div>
</div>
<br>
<span style="background-color:rgb(255,255,255)"><font size="2">This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.</font></span>