<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Dear Stephen,<br>
<br>
Thank you very much for your answer. It helps me a lot, but I have
further questions. Please see my comments inline.<br>
<span style="white-space: pre-wrap">
</span>
<blockquote type="cite"
cite="mid:20250807105703.22de669d@hermes.local">
<pre class="moz-quote-pre" wrap="">The pseudo-header part is different.
</pre>
</blockquote>
If I understand it correctly, then it means that I need to write the
ICMPv6 checksum function myself. To that end, I reviewed the source
code of the <span style="white-space: pre-wrap">"rte_ipv6_udptcp_cksum()" function so that I can learn from it. However, I did not find where it differs from the one that I need.
I took the below source code from here: <a class="moz-txt-link-freetext" href="https://doc.dpdk.org/api/rte__ip6_8h_source.html#l00610">https://doc.dpdk.org/api/rte__ip6_8h_source.html#l00610</a>
<font face="monospace">rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const void *l4_hdr)
{
uint16_t cksum = __rte_ipv6_udptcp_cksum(ipv6_hdr, l4_hdr);
cksum = ~cksum;
/*
* Per RFC 768: If the computed checksum is zero for UDP,
* it is transmitted as all ones
* (the equivalent in one's complement arithmetic).
*/
if (cksum == 0 && ipv6_hdr->proto == IPPROTO_UDP)
cksum = 0xffff;
return cksum;
}
</font></span>It is the highest level. It calls an internal function and
at the end it considers the protocol number (with other words, the
next header field of the IPv6 header) when it handles UDP specific
things, thus I think that this time it does not cause any problem in
the case of ICMPv6.<br>
<br>
This is the source code of the internal function:<br>
<br>
<font face="monospace">static inline uint16_t<br>
__rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const
void *l4_hdr)<br>
{<br>
uint32_t cksum;<br>
uint32_t l4_len;<br>
<br>
l4_len = rte_be_to_cpu_16(ipv6_hdr->payload_len);<br>
<br>
cksum = rte_raw_cksum(l4_hdr, l4_len);<br>
cksum += rte_ipv6_phdr_cksum(ipv6_hdr, 0);<br>
<br>
cksum = ((cksum & 0xffff0000) >> 16) + (cksum &
0xffff);<br>
<br>
return (uint16_t)cksum;<br>
}<br>
<br>
</font>It calculates the checksum for the L4 part and also for the
pseudo-header separately. The latter could be different than what I
need for ICMPv6.<br>
<br>
I also checked the source code of "<font face="monospace">rte_ipv6_phdr_cksum(ipv6_hdr,
0)</font>", please see it below the figure from RFC 2460.<br>
<br>
<span style="white-space: pre-wrap">
</span><span style="white-space: pre-wrap">
</span>
<blockquote type="cite"
cite="mid:20250807105703.22de669d@hermes.local">
<pre class="moz-quote-pre" wrap=""><a class="moz-txt-link-freetext" href="https://www.rfc-editor.org/rfc/rfc4443">https://www.rfc-editor.org/rfc/rfc4443</a>
2.3. Message Checksum Calculation
The checksum is the 16-bit one's complement of the one's complement
sum of the entire ICMPv6 message, starting with the ICMPv6 message
type field, and prepended with a "pseudo-header" of IPv6 header
fields, as specified in [IPv6, Section 8.1]. The Next Header value
used in the pseudo-header is 58. (The inclusion of a pseudo-header
in the ICMPv6 checksum is a change from IPv4; see [IPv6] for the
rationale for this change.)
For computing the checksum, the checksum field is first set to zero.
<a class="moz-txt-link-freetext" href="https://www.rfc-editor.org/rfc/rfc2460#section-8.1">https://www.rfc-editor.org/rfc/rfc2460#section-8.1</a>
8.1 Upper-Layer Checksums
Any transport or other upper-layer protocol that includes the
addresses from the IP header in its checksum computation must be
modified for use over IPv6, to include the 128-bit IPv6 addresses
instead of 32-bit IPv4 addresses. In particular, the following
illustration shows the TCP and UDP "pseudo-header" for IPv6:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| |
+ +
| |
+ Source Address +
| |
+ +
| |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| |
+ +
| |
+ Destination Address +
| |
+ +
| |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| Upper-Layer Packet Length |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| zero | Next Header |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
</pre>
</blockquote>
<br>
So this is what I need. And it seems to me, that the below source
code does exactly the same:<br>
<font face="monospace"><br>
static inline uint16_t<br>
rte_ipv6_phdr_cksum(const struct rte_ipv6_hdr *ipv6_hdr, uint64_t
ol_flags)<br>
{<br>
uint32_t sum;<br>
struct {<br>
rte_be32_t len; /* L4 length. */<br>
rte_be32_t proto; /* L4 protocol - top 3 bytes must be
zero */<br>
} psd_hdr;<br>
<br>
psd_hdr.proto = (uint32_t)(ipv6_hdr->proto << 24);<br>
if (ol_flags & (RTE_MBUF_F_TX_TCP_SEG |
RTE_MBUF_F_TX_UDP_SEG))<br>
psd_hdr.len = 0;<br>
else<br>
psd_hdr.len = ipv6_hdr->payload_len;<br>
<br>
sum = __rte_raw_cksum(&ipv6_hdr->src_addr,<br>
sizeof(ipv6_hdr->src_addr) +
sizeof(ipv6_hdr->dst_addr),<br>
0);<br>
sum = __rte_raw_cksum(&psd_hdr, sizeof(psd_hdr), sum);<br>
return __rte_raw_cksum_reduce(sum);<br>
}<br>
</font><br>
As required, it handles length field on 32 bits, and shifts the
protocol field (containing the value of 58) to the left by 24 bit,
which means the same as the "next header" field is at the topmost 8
bits of a 32 bit number in the drawing. <br>
<br>
Then it does a "trick" that it uses the source and destination IPv6
addresses from the IPv6 packet (likely to spare their copying). <br>
<br>
Thus, I did not find anything what I would need to do differently. <br>
<br>
However, on the other hand, <u>there should be something</u>,
because I tried using the <span style="white-space: pre-wrap">"rte_ipv6_udptcp_cksum()" function (of course, I set the checksum field to 0 before using it), but Wireshark said that the checksum was incorrect.
Both tshark and </span><span style="white-space: pre-wrap">Wireshark decodes my NA message perfectly, but the Linux kernel of the device under test does not accept it, this is why it sends further NS messages.</span><br>
<br>
This is a tshark capture on the device under test:<br>
<font face="monospace"><br>
root@dut:~# tshark -i eno1
<br>
Running as user "root" and group "root". This could be dangerous.
<br>
Capturing on 'eno1'
<br>
1 0.000000000 fe80::baca:3aff:fe5e:25a8 → ff02::16 ICMPv6
170 Multicast Listener Report Message v2
<br>
2 0.379986848 fe80::baca:3aff:fe5e:25a8 → ff02::16 ICMPv6
170 Multicast Listener Report Message v2
<br>
3 4.156047617 2001:2::2 → 2001:2:0:8000::2 UDP 80 58488 →
27971 Len=18
<br>
4 4.156066982 fe80::baca:3aff:fe5e:25a8 → ff02::1:ff00:2
ICMPv6 86 Neighbor Solicitation for 2001:2::2 from
b8:ca:3a:5e:25:a8
<br>
5 4.156092949 2001:2::2 → fe80::baca:3aff:fe5e:25a8 ICMPv6
86 Neighbor Advertisement 2001:2::2 (ovr) is at 24:6e:96:3c:3f:40
<br>
6 5.183987802 fe80::baca:3aff:fe5e:25a8 → ff02::1:ff00:2
ICMPv6 86 Neighbor Solicitation for 2001:2::2 from
b8:ca:3a:5e:25:a8
<br>
7 5.184007499 2001:2::2 → fe80::baca:3aff:fe5e:25a8 ICMPv6
86 Neighbor Advertisement 2001:2::2 (ovr) is at 24:6e:96:3c:3f:40
<br>
8 6.203987286 fe80::baca:3aff:fe5e:25a8 → ff02::1:ff00:2
ICMPv6 86 Neighbor Solicitation for 2001:2::2 from
b8:ca:3a:5e:25:a8
<br>
9 6.204007429 2001:2::2 → fe80::baca:3aff:fe5e:25a8 ICMPv6
86 Neighbor Advertisement 2001:2::2 (ovr) is at 24:6e:96:3c:3f:40
<br>
10 7.232005250 2001:2::1 → ff02::1:ff00:2 ICMPv6 86 Neighbor
Solicitation for 2001:2::2 from b8:ca:3a:5e:25:a8
<br>
11 8.251987771 fe80::baca:3aff:fe5e:25a8 → ff02::1:ff00:2
ICMPv6 86 Neighbor Solicitation for 2001:2::2 from
b8:ca:3a:5e:25:a8
<br>
12 9.275986860 fe80::baca:3aff:fe5e:25a8 → ff02::1:ff00:2
ICMPv6 86 Neighbor Solicitation for 2001:2::2 from
b8:ca:3a:5e:25:a8
</font><br>
<br>
And Wireshark says: "Checksum: 0x1baf incorrect, should be 0x035d".<br>
<br>
Could you please advise me, what I could overlook?<br>
<br>
Best regards,<br>
<br>
Gábor<br>
<br>
<br>
</body>
</html>