[dpdk-ci] [PATCH v4 07/10] tools: filter new Patchwork IDs by date
Ali Alnubani
alialnu at nvidia.com
Mon Nov 8 07:28:12 CET 2021
API resource IDs are guaranteed to be unique, but they aren't guaranteed
to have no gaps, for example, the following series IDs are
nonexistent: 16157, 17181, 18235.
Filtering by the date since the last check is necessary to later
add support for fetching new series IDs in addition to patch IDs.
The script now periodically fetches Patchwork's events API filtering
by the 'patch-completed' category (see [1]). It parses the responses using jq
and passes the IDs to 'callcmd'.
Instead of requiring a file that contains the next patch ID,
a file containing the timestamp of the last time the API was fetched
is now used. Each time the API is fetched for new patches, the timestamp
in the file gets updated, and the script sleeps an amount of time specified
by PAUSE_SECONDS before attempting to fetch new resources again.
There are 2 variables, 'date_now', which is recorded right before
fetching from the API, and then gets written to the file, and 'since',
which is the last date that was written to the file.
Since API responses can be in multiple pages, the script will keep
attempting to fetch the next page until jq encounters an error while
parsing a non list response with no 'payload' key.
The pause amount between each poll attempt is still 100 seconds.
The script writes the date in Universal Time (UTC) format and
expects to read the same format from the file as Patchwork stores event
objects with a naive datetime object that is not aware of the
server's timezone (see [2] and [3]).
The package jq (Command-line JSON processor) is now required by the
script.
Example usage:
$ export MAINTAINERS_FILE_PATH=/path/to/dpdk/MAINTAINERS
$ ./tools/poll-pw /path/to/last.txt \
'/path/to/pw_maintainers_cli.py --type patch set-pw-delegate $1'
[1] https://patchwork.readthedocs.io/en/latest/usage/overview/#patch-completed
[2] https://github.com/getpatchwork/patchwork/blob/580cc8570a05c1/patchwork/models.py#L1058
[3] https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow
Signed-off-by: Ali Alnubani <alialnu at nvidia.com>
---
Changes in v2:
- Removed an unnecessary 'break' statement in the for loop.
Changes in v3:
- Fetch the events API endpoint for new patches as the date field in the
/patches and /series endpoints is the mbox creation date, not
the date they were created in Patchwork.
- Use UTC date format.
- Redirect error messages to stderr.
- Fixed typo in usage (specifed -> specified).
tools/poll-pw | 63 ++++++++++++++++++++++++++++++++++-----------------
1 file changed, 42 insertions(+), 21 deletions(-)
diff --git a/tools/poll-pw b/tools/poll-pw
index bdf860a..ccc58f0 100755
--- a/tools/poll-pw
+++ b/tools/poll-pw
@@ -1,58 +1,79 @@
-#! /bin/sh -e
+#! /bin/sh
# SPDX-License-Identifier: BSD-3-Clause
# Copyright 2017 6WIND S.A.
# Copyright 2018 Mellanox Technologies, Ltd
URL=http://patches.dpdk.org/api
+PAUSE_SECONDS=100
print_usage () {
cat <<- END_OF_HELP
- usage: $(basename $0) <counter> <command>
+ usage: $(basename $0) [OPTIONS] </path/to/last.txt> <command>
Poll patchwork and call command for each patch.
- The first patchwork id to be checked is read from the counter file.
- The command should use '$1' to be evaluated as patchwork id.
- When a patch is found and the command is successful,
- then the counter is incremented.
+ The first date to filter with is read from the specified file.
+ The command should use '$1' to be evaluated as the patch id.
+ The date in the specified file is updated after each pull.
END_OF_HELP
}
+which jq >/dev/null 2>&1
+if [ ! $? -eq 0 ] ; then
+ printf "The command 'jq' doesn't exist, please install it.\n\n" >&2
+ exit 1
+fi
+
while getopts h arg ; do
case $arg in
h ) print_usage ; exit 0 ;;
? ) print_usage >&2 ; exit 1 ;;
esac
done
+
if [ $# -lt 2 ] ; then
- printf 'missing argument\n\n' >&2
+ printf 'missing argument(s)\n\n' >&2
print_usage >&2
exit 1
fi
shift $(($OPTIND - 1))
-counter=$1
+since_file=$1
shift
cmd=$*
+if [ ! -f "$since_file" ] ; then
+ printf "The file '$since_file' doesn't exist.\n\n" >&2
+ exit 1
+fi
+
+date -d "$(cat $since_file | tr '\n' ' ')" >/dev/null 2>&1
+if [ ! $? -eq 0 ] ; then
+ printf "The file '$since_file' doesn't contain a valid date format.\n\n" >&2
+ exit 1
+fi
+
+URL="${URL}/events/?category=patch-completed"
+
callcmd () # <patchwork id>
{
eval $cmd
}
-checkid () # <patchwork id>
-{
- curl -sfIo /dev/null $URL/patches/$1/ ||
- curl -sfIo /dev/null $URL/covers/$1/
-}
-
-pwid=$(cat $counter)
+set -e
while true ; do
- # process all recent patches
- while checkid $pwid ; do
- callcmd $pwid || break
- pwid=$(($pwid + 1))
- echo $pwid >$counter
+ date_now=$(date --utc '+%FT%T')
+ since=$(date -d $(cat $since_file | tr '\n' ' ') '+%FT%T')
+ page=1
+ while true ; do
+ ids=$(curl -s "${URL}&page=${page}&since=${since}" \
+ | jq 'try ( .[].payload.patch.id )')
+ [ -z "$(echo $ids | tr -d '\n')" ] && break
+ for id in $ids ; do
+ callcmd $id
+ done
+ page=$((page+1))
done
+ echo -n $date_now >$since_file
# pause before next check
- sleep 100
+ sleep $PAUSE_SECONDS
done
--
2.25.1
More information about the ci
mailing list