[dpdk-ci] [PATCH 2/2] guess_git_tree: edge case and style changes

Ali Alnubani alialnu at oss.nvidia.com
Mon Oct 11 19:38:06 CEST 2021


> -----Original Message-----
> From: ci <ci-bounces at dpdk.org> On Behalf Of ohilyard at iol.unh.edu
> Sent: Friday, September 24, 2021 7:05 PM
> To: ci at dpdk.org
> Cc: aconole at redhat.com; Owen Hilyard <ohilyard at iol.unh.edu>
> Subject: [dpdk-ci] [PATCH 2/2] guess_git_tree: edge case and style changes
> 
> From: Owen Hilyard <ohilyard at iol.unh.edu>
> 
> The import statements in the file have been moved below the module doc
> comment per PEP 257.
> 
> A sanity check has been added to find_filenames. Occasionally, due to
> how the community lab internally handles getting patches from
> patchworks, a patch will result in no diff. This patch adds handling for
> this case.
> 
> Signed-off-by: Owen Hilyard <ohilyard at iol.unh.edu>
> ---

The subject (commit summary) should be an imperative sentence (see https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line).
I also think it would be better to split this into 2 patches (one for the style fix, and one for the empty list).

Thanks,
Ali


More information about the ci mailing list