[dpdk-ci] [PATCH v2 03/10] tools: update script usage
alialnu at oss.nvidia.com
alialnu at oss.nvidia.com
Tue Sep 21 16:35:35 CEST 2021
From: Ali Alnubani <alialnu at nvidia.com>
The resource type (whether it's a patch or a series) is now
specified by the new argument --type.
Both commands: list_trees_for_patch & list_trees_for_series
are replaced by the positional arg 'list_trees', and the type must
be always set.
This makes adding more operations require less arguments.
Signed-off-by: Ali Alnubani <alialnu at nvidia.com>
---
tools/pw_maintainers_cli.py | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/tools/pw_maintainers_cli.py b/tools/pw_maintainers_cli.py
index 343e9f5..d4c0056 100755
--- a/tools/pw_maintainers_cli.py
+++ b/tools/pw_maintainers_cli.py
@@ -31,8 +31,8 @@ variables PW_{SERVER,PROJECT,TOKEN} should be set. If not, the script will try
to load the git configurations pw.{server,project,token}.
Example usage:
- ./pw_maintainers_cli.py --command list_trees_for_series 2054
- ./pw_maintainers_cli.py --command list_trees_for_patch 2054
+ ./pw_maintainers_cli.py --type series list_trees 2054
+ ./pw_maintainers_cli.py --type patch list_trees 2054
Or if you want to use inside other scripts:
@@ -238,14 +238,14 @@ if __name__ == '__main__':
"""Main procedure."""
parser = argparse.ArgumentParser()
git_pw_conf_parser = parser.add_argument_group('git-pw configurations')
- options_parser = parser.add_argument_group('optional arguments')
+ required_args_parser = parser.add_argument_group('required arguments')
- options_parser.add_argument(
- '--command',
+ required_args_parser.add_argument(
+ '--type',
choices=(
- 'list_trees_for_patch',
- 'list_trees_for_series'),
- required=True, help='Command to perform')
+ 'patch',
+ 'series'),
+ required=True, help='Resource type.')
git_pw_conf_parser.add_argument(
'--pw_server', type=str,
@@ -262,12 +262,18 @@ if __name__ == '__main__':
default=os.environ.get('PW_TOKEN', utils.git_config('pw.token')),
help='Authentication token')
+ parser.add_argument(
+ 'command',
+ choices=[
+ 'list_trees'],
+ help='Command to perform')
parser.add_argument(
'id', type=int, help='patch/series id')
args = parser.parse_args()
command = args.command
+ resource_type = args.type
_id = args.id
# Pass the needed configurations to git-pw.
@@ -279,9 +285,9 @@ if __name__ == '__main__':
maintainers = Maintainers()
patch_list = []
- if command == 'list_trees_for_patch':
+ if resource_type == 'patch':
patch_list.append(_git_pw.api_get('patches', _id))
- elif command == 'list_trees_for_series':
+ else:
series = _git_pw.api_get('series', _id)
patch_list = [
_git_pw.api_get('patches', patch['id'])
@@ -290,4 +296,8 @@ if __name__ == '__main__':
files = []
for patch in patch_list:
files += Diff.find_filenames(patch['diff'])
- print(maintainers.get_tree(files).split('/')[-1])
+
+ tree = maintainers.get_tree(files)
+
+ if command == 'list_trees':
+ print(tree.split('/')[-1])
--
2.25.1
More information about the ci
mailing list