[PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff
Aaron Conole
aconole at redhat.com
Wed Jun 21 20:38:28 CEST 2023
Patrick Robb <probb at iol.unh.edu> writes:
> Patrick, are [1/3] and [2/3] still needed as well?
>
> Yes please on both. We are currently using 1/3 in our Jenkins process for including tag arguments in creating
> the execution file. Thanks for raising this.
Looks like this slipped my queue. I'll apply it now.
Thanks.
>
>
> On Wed, Jun 21, 2023 at 11:19 AM Ali Alnubani <alialnu at nvidia.com> wrote:
>
> > -----Original Message-----
> > From: Ali Alnubani <alialnu at nvidia.com>
> > Sent: Monday, February 7, 2022 5:56 PM
> > To: ohilyard at iol.unh.edu; ci at dpdk.org
> > Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff
> >
> > > -----Original Message-----
> > > From: ohilyard at iol.unh.edu <ohilyard at iol.unh.edu>
> > > Sent: Monday, February 7, 2022 5:08 PM
> > > To: ci at dpdk.org; Ali Alnubani <alialnu at nvidia.com>
> > > Cc: Owen Hilyard <ohilyard at iol.unh.edu>
> > > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff
> > >
> > > From: Owen Hilyard <ohilyard at iol.unh.edu>
> > >
> > > A sanity check has been added to find_filenames. Occasionally, due to
> > > how the community lab internally handles getting patches from
> > > patchworks, a patch will result in no diff. This patch adds handling for
> > > this case.
> > >
> > > Signed-off-by: Owen Hilyard <ohilyard at iol.unh.edu>
> > > ---
> >
> > Thanks Owen.
> >
> > Tested-by: Ali Alnubani <alialnu at nvidia.com>
> > Acked-by: Ali Alnubani <alialnu at nvidia.com>
>
> Hi Thomas and Aaron,
>
> Can we merge this patch? Pull requests can still cause the script to crash because they have an empty
> diff.
>
> Patrick, are [1/3] and [2/3] still needed as well?
>
> Thanks,
> Ali
More information about the ci
mailing list