[PATCH v6 3/6] containers/builder: Dockerfile creation script

[Adam Hassick]

This script is not intended to be run by the end user on their machine's
bare environment. The CI worker container will acquire the needed python
version to run this script when the container is built; the end user does
not need to install python 3.10 themselves. The
"make_docker_files_in_container" target in the Makefile is the intended way
to call this script. The build and push targets then depend on that target.

To me, this appears fine, but let me know if you have any concerns.

On Thu, Jun 22, 2023 at 11:55 AM Ali Alnubani <alialnu at nvidia.com> wrote:

> > -----Original Message-----
> > From: Adam Hassick <ahassick at iol.unh.edu>
> > Sent: Thursday, May 25, 2023 8:15 PM
> > To: ci at dpdk.org
> > Cc: aconole at redhat.com; Ali Alnubani <alialnu at nvidia.com>; Owen Hilyard
> > <ohilyard at iol.unh.edu>; Adam Hassick <ahassick at iol.unh.edu>
> > Subject: [PATCH v6 3/6] containers/builder: Dockerfile creation script
> >
> > From: Owen Hilyard <ohilyard at iol.unh.edu>
> >
> > This script will template out all of the Dockerfiles based on the
> > definitions provided in the inventory using the jinja2 templating
> > library.
> >
> [..]
> > +
> > +def get_host_arch() -> str:
> > +    machine: str = platform.machine()
> > +    match machine:
>
> This adds a nondocumented dependency on Python 3.10.
>


-- 
*Adam Hassick*
Senior Developer
UNH InterOperability Lab
ahassick at iol.unh.edu
iol.unh.edu <https://www.iol.unh.edu/>
+1 (603) 475-8248
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/ci/attachments/20230622/c79dfaa4/attachment-0001.htm>