[EXT] Re: [PATCH] pw_maintainers_cli: enhance tree selection
Pavan Nikhilesh Bhagavatula
pbhagavatula at marvell.com
Fri Sep 29 12:54:26 CEST 2023
> >
> > > -----Original Message-----
> > > From: pbhagavatula at marvell.com <pbhagavatula at marvell.com>
> > > Sent: Friday, September 29, 2023 2:05 PM
> > > To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; alialnu at nvidia.com;
> > > aconole at redhat.com
> > > Cc: ci at dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula at marvell.com>
> > > Subject: [PATCH] pw_maintainers_cli: enhance tree selection
> > >
> > > From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> > >
> > > When longest prefix match doesnt find a suitable tree, pick the
> > > tree which has the highest modified file count instead of defauting
> > > to main tree.
> > >
> >
> > This change is need to find the correct branch when a patch has a
> specification
> > Change followed by a implementation of driver layer example:
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_list_-3Fseries-
> 3D29675&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB-
> fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=WKN1erKSjH9MuEyyRs-
> R3jYC5geZeUeNipx2GQlQpQSuQQCet70Torr1oSdZNvZp&s=6XFs2Ggg5G0VFd
> YEaRexumEXM5JKc2vs5dmrRNcIUZw&e=
>
> That's expected: when a series touches more than a tree scope,
> it goes to main.
> But that's not the issue here.
> Both eventdev lib, test and drivers belong to the eventdev tree.
> So why it is not already delegated to eventdev?
> Please dig more.
>
>
The main issue is the driver implementation touches common/cnxk which ties it to
next-net-mrvl tree which causes the conflict.
We have few options here,
1. Based on max number of files touched per tree (Current patch)
2. Ignore driver/common from tree selection when there is a conflict with other tree.
3. When there is a conflict between trees choose the common tree instead of company specific tree
Example, dpdk-next-eventdev + dpdk-next-net-mrvl = dpdk-next-eventdev
More information about the ci
mailing list