[PATCH] tools: run check-meson.py in create_series_artifact
Manit Mahajan
mmahajan at iol.unh.edu
Thu Oct 24 20:35:00 CEST 2024
The check-meson.py is a python script that runs checks on
Meson.build files in DPDK. Checks include, splitting a line into a
code part and a comment part, list of files are correctly indented,
and more. Updating create_series_artifact.py to run the
check-meson.py so check-meson.py can be run on all
incoming patches. In UNH CI, we will report a build failure if the
check-meson.py reports an error.
Signed-off-by: Manit Mahajan <mmahajan at iol.unh.edu>
---
tools/create_series_artifact.py | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/tools/create_series_artifact.py b/tools/create_series_artifact.py
index 550ea82..bfc97f8 100755
--- a/tools/create_series_artifact.py
+++ b/tools/create_series_artifact.py
@@ -251,6 +251,24 @@ class ProjectTree(object):
self.set_properties(apply_error=error)
return not error
+
+ def check_meson(self) -> bool:
+
+ result = subprocess.run(
+ ['python', os.path.join(self.path, "devtools/check-meson.py"), '-d', str(self.path), '-v'],
+ cwd=self.path,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE,
+ )
+
+ self.log("Running Check Meson")
+ self.log(result.stdout.decode())
+ self.log(result.stderr.decode())
+
+ error = "Error" in result.stdout.decode()
+ self.set_properties(meson_error=error)
+ return not error
+
def test_build(self) -> bool:
ninja_result: Optional[subprocess.CompletedProcess] = None
meson_result: subprocess.CompletedProcess = subprocess.run(
@@ -454,8 +472,14 @@ def collect_series_info(args: argparse.Namespace) -> CreateSeriesParameters:
def try_to_apply(tree: ProjectTree) -> bool:
- return tree.apply_patch_series() and tree.test_build() and tree.create_tarball()
+ artifact_build_result = True
+ artifact_build_result &= tree.apply_patch_series()
+ artifact_build_result &= tree.check_meson()
+ artifact_build_result &= tree.test_build()
+ artifact_build_result &= tree.create_tarball()
+
+ return artifact_build_result
def main() -> int:
data = collect_series_info(parse_args())
--
2.41.0
More information about the ci
mailing list