[dpdk-dev] [PATCH] eal: check coremask against detected lcores

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Apr 18 00:43:16 CEST 2014


> > lcores that are set in coremask should be checked against lcores detected
> > on system. This way, we won't need to check them later.
> > 
> > Besides, if specifying an unavailable lcore, we currently panic in
> > eal_thread_loop() because pthread_setaffinity_np fails.
> > So this check will return an error with a more explicit message in
> > eal_parse_coremask().
> > 
> > "EAL: pthread_setaffinity_np failed
> > 
> >  PANIC in eal_thread_loop():
> >  cannot set affinity"
> > 
> > becomes :
> > 
> > "EAL: lcore 4 unavailable
> > 
> >  EAL: invalid coremask"
> > 
> > Signed-off-by: David Marchand <david.marchand at 6wind.com>
> 
> Acked-by: Neil Horman <nhorman at tuxdriver.com>

Applied for version 1.6.0r2.

Thanks for this nice usability improvement
-- 
Thomas


More information about the dev mailing list