[dpdk-dev] [RFC PATCH 11/14] ixgbe: make mbuf_initializer queue variable global

Richardson, Bruce bruce.richardson at intel.com
Tue Aug 12 00:03:47 CEST 2014


> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Monday, August 11, 2014 2:48 PM
> To: Richardson, Bruce
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH 11/14] ixgbe: make mbuf_initializer queue
> variable global
> 
> On Mon, 11 Aug 2014 21:44:47 +0100
> Bruce Richardson <bruce.richardson at intel.com> wrote:
> 
> > On descriptor rearm, the mbuf_initializer variable can be used to do a
> > single-shot write to an mbuf to initialize all variables that can be
> > set. This is currently used only by vector PMD function, but now allow
> > it to be generally used by other RX code paths.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > ---
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx.c     | 25 +++++++++++++++++++++++--
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx.h     |  9 ++++++---
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 25 +------------------------
> >  3 files changed, 30 insertions(+), 29 deletions(-)
> 
> 
> These patches from 11-14 are really a follow on thread to the original
> changes. The sequence could be shorter so that reviewers digest 1-10 first.

Ok. The whole patch sequence needs to be cleaned up a lot before it's ready to go into the code, so I'll try and keep that in mind when doing the cleanup.


More information about the dev mailing list