[dpdk-dev] [PATCH] enic: fix warnings

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Dec 4 11:48:29 CET 2014


2014-12-04 10:29, Sujith Sankar:
> 
> On 02/12/14 8:29 pm, "Thomas Monjalon" <thomas.monjalon at 6wind.com> wrote:
> 
> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set
> >in the Makefile. But they appear with toolchains that enforce more checks.
> >
> >-Wno-deprecated seems useless.
> >-Wno-strict-aliasing is added to avoid false positives.
> >
> >This patch cleans up unused variable, unused functions, wrong types,
> >static declarations, etc. A lot of functions have unused parameters;
> >it suggests that more clean-up could be needed.
> >
> >Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> >---
> > lib/librte_pmd_enic/Makefile         |  3 +-
> > lib/librte_pmd_enic/enic.h           |  4 +-
> > lib/librte_pmd_enic/enic_ethdev.c    | 20 ++++-----
> 
> Thomas, the name of this file got modified.  It was enic_etherdev.c in my
> submission.
> Any idea how this happened?  I do not remember seeing a request for this.

Yes, sorry I forgot to request it.
I renamed the file to be consistent with other drivers.
Everywhere in DPDK we talk about ethdev for device operations, not etherdev.

-- 
Thomas


More information about the dev mailing list