[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

[Gonzalez Monroy, Sergio]

> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Monday, December 22, 2014 4:35 PM
> 
> On Mon, Dec 22, 2014 at 02:01:10PM +0000, Gonzalez Monroy, Sergio wrote:
> >
> > > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > > Sent: Saturday, December 20, 2014 9:02 PM
> > We could move the ifneq($(LIB),) to the _INSTALL variable (top of the same
> file).
> > Something like this:
> >
> > -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
> > $(RTE_OUTPUT)/lib/$(LIB)
> > +_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) ifneq ($(LIB),)
> > +_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) endif
> >
> Actually, as I look at it, this second one doesn't seem to make any sense to
> me.
> _INSTALL as a variable doesn't seem to get used anywhere that I can see,
> certainly not in the capacity of copying shared libraries into the build/lib area
> so that the example apps can get linked with them.  So I'm not sure this
> makes sense.
> 
The _INSTALL var gets expanded for the rule '_install' in mk/internal/rte.install-post.mk if I am not mistaken.
That would trigger the rule $(RTE_OUTPUT)/lib/$(LIB) which in turn builds and copy the shared/static library to build/lib.

If we do not add $(RTE_OUTPUT)/lib/$(LIB) to _INSTALL, then the rule will not trigger.

Regards,
Sergio

> Neil
>