[dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop

Ouyang, Changchun changchun.ouyang at intel.com
Mon Jul 28 06:34:23 CEST 2014


Hi Thomas,
I have generated patch v2 to resolve this according to your comments.
Pls see attachment.
Thanks and regards,
Changchun

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] 
Sent: Tuesday, July 22, 2014 5:38 PM
To: Ouyang, Changchun
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop

Hi,

2014-07-22 15:47, Ouyang Changchun:
> This patch series include 3 things:
> 1) Rename the field name from start_rx_per_q to rx_enable_queue in 
> struct rte_eth_rxconf, and do same thing for TX.
> This patch also update description for field rx_enable_queue and tx_enable_queue.
> 2) According to 1), update field name from start_rx_per_q to 
> rx_enable_queue in struct igb_rx_queue  in ixgbe PMD, do same thing for TX.
> 3) Update its reference in sample vhost.

In order to be atomic (and do not break git bisect), you should submit it in one patch.
Title would be "ethdev: rename queue enabler field" or something like that.
But the most important in such change is to explain why you make it.

Thanks
--
Thomas


More information about the dev mailing list