[dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions

Richardson, Bruce bruce.richardson at intel.com
Thu Jun 12 00:27:31 CEST 2014


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, June 11, 2014 3:19 PM
> To: Richardson, Bruce
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/2] 10G PMD: vectorized RX and TX
> functions
> 
> Hi Bruce,
> 
> You are introducing a new option CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE.
> I feel a comment in the code would be helpful here.

Comment in the code, or in the config file where the option is defined?

> 
> Sorry for not having checked before but there are some checkpatch issues
> in this PMD.
> Other simple cleanup: I think some include directives are useless.
> 
> Could you rework a new version please?
> 
Ack. I'll see what I can do.


More information about the dev mailing list