[dpdk-dev] [PATCH 6/7] i40evf: fix for copying wrong size of link info, and remove an useless function
Thomas Monjalon
thomas.monjalon at 6wind.com
Fri Jun 20 16:28:34 CEST 2014
2014-06-20 14:14, Helin Zhang:
> Delete the inline function which is not used at this moment.
> Fix the bug of copying wrong size of link info in function of
> i40evf_get_link_status().
There are 2 patches here. Please split.
> static inline int
> -i40evf_dev_atomic_read_link_status(struct rte_eth_dev *dev,
> - struct rte_eth_link *link)
> -{
> - struct rte_eth_link *dst = link;
> - struct rte_eth_link *src = &(dev->data->dev_link);
> -
> - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
> - *(uint64_t *)src) == 0)
> - return -1;
> -
> - return 0;
> -}
Not directly related to this patch, but it could be a good idea to start
using rte_eth_dev_atomic_read_link_status() instead of copying this function
in each PMD.
--
Thomas
More information about the dev
mailing list