[dpdk-dev] [PATCH v2 7/7] app/testpmd: rework for displaying different size of RX descriptors

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Jun 23 17:43:41 CEST 2014


Hi Helin,

Thanks for this new patchset version.

2014-06-23 20:57, Helin Zhang:
> i40e supports 16 and 32 bytes RX descriptors which can be configured.
> It needs to check the driver type and the configuration to determine
> if 16 or 32 bytes RX descriptors is being used, for reading and
> displaying the different sizes of RX descriptors.
> 
> Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> Acked-by: Jing Chen <jing.d.chen at intel.com>
> Acked-by: Cunming Liang <cunming.liang at intel.com>

Just before applying theses patches, I checked with checkpatch.pl which warned 
me about this:

> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].lo_dword));
> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].hi_dword));
> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].resv1));
> +		ring_rxd_display_dword(rte_le_to_cpu_64(\
> +				ring[desc_id].resv2));

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations

Could you remove it please?

Thanks
-- 
Thomas


More information about the dev mailing list