[dpdk-dev] [PATCH] string: fix potential seg fault on snprintf

[Olivier MATZ]

Hello Pablo,

On 06/27/2014 01:04 PM, Pablo de Lara wrote:
> From: Pablo de Lara <pablo.de.lara.guarch at intel.com>
>
> Several functions did not check if destination buffer, used
> in snprintf was a non-NULL pointer.

Did you noticed any issue without this patch?

It seems that all the get_help() cmdline functions are never called
with a NULL destination buffer (see in cmdline_parse.c). I think it
is useless to add this test as there is no good reason to give a NULL
argument. It is like testing that the arguments of strcpy() are
non-NULL.

I would say the same for pci_get_uio_dev().

Regards,
Olivier