[dpdk-dev] [PATCH] mk: fix dependencies when modifying config

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Mar 26 23:14:41 CET 2014


2014-03-26 17:08, Olivier MATZ: 
> On 03/19/2014 12:36 PM, Thomas Monjalon wrote:
> > If .config file is changed and .depdirs was built before,
> > it must be updated.
> > It is now done silently (-s) in checkconfig rule.
> > Now .depdirs is not redone if .config is older.
> > 
> > It has been tested by enabling PMD_PCAP after a default build.
> > KVARGS dependency should appear in .depdirs.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> 
> Looks good to me. Just see one comment below.
> 
> >   ..PHONY: depdirs
> 
> It seems there is a typo (..PHONY instead of .PHONY), it could
> be a good occasion to fix it. In my opinion, it can be done in the
> same patch as this typo does not create a real issue.

Applied with the typo fix.

Thanks for the review
-- 
Thomas


More information about the dev mailing list