[dpdk-dev] [PATCH] pcap: remove test for PCAP_CAN_SEND

Neil Horman nhorman at tuxdriver.com
Sat Mar 29 02:32:29 CET 2014

The libpcap library has had the ability to send packets since 2004, theres
really no need to test for it.  Especially in the way dpdk is doing as, as
according to the libpcap git tree pcap_sendpacket has never been a #define, and
dpdk tests for its existance with an #ifdef.  Its easier just to remove the test

Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
 lib/librte_pmd_pcap/rte_eth_pcap.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c
index fbafd19..fe94a79 100644
--- a/lib/librte_pmd_pcap/rte_eth_pcap.c
+++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
@@ -217,7 +217,6 @@ eth_pcap_tx_dumper(void *queue,
 	return num_tx;
  * Callback to handle sending packets through a real NIC.
@@ -248,17 +247,6 @@ eth_pcap_tx(void *queue,
 	tx_queue->err_pkts += nb_pkts - num_tx;
 	return num_tx;
-static uint16_t
-eth_pcap_tx(__rte_unused void *queue,
-		__rte_unused struct rte_mbuf **bufs,
-		__rte_unused uint16_t nb_pkts)
-	RTE_LOG(ERR, PMD, "pcap library cannot send packets, please rebuild "
-	                  "with a more up to date libpcap\n");
-	return -1;
 static int
 eth_dev_start(struct rte_eth_dev *dev)

More information about the dev mailing list