[dpdk-dev] [PATCH] mk: allow updates to build config on make install

Thomas Monjalon thomas.monjalon at 6wind.com
Wed May 14 12:33:46 CEST 2014


Hi Bruce

2014-05-14 11:22, Bruce Richardson:
> There was an issue with rebuilding the code following a change to
> one of the config files inside the "config" directory. If one did
> a "make install T=<target>" and then made a modification to the
> defconfig_<target> file (or applied a patch which modified that file)
> a subsequent re-run of the make install command would not rebuild
> the .config file leading to either build failures or an incorrect
> build. This change fixes that issue.

Your patch is reverting this one:
	mk: in install rule, don't overwrite .config if it already exists
	http://dpdk.org/browse/dpdk/commit/?id=1c858a7dfebd4e4092eb55
As stated in the commit log,
	"This allows the user to prepare a configuration with make config
	before using make install."

So your patch is introducing a regression.

I think you are describing something which is not a bug.
If you make a modification to the configuration template, you must explicitly 
call "make config".

-- 
Thomas


More information about the dev mailing list