[dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line
Thomas Monjalon
thomas.monjalon at 6wind.com
Wed May 28 13:24:51 CEST 2014
2014-05-28 10:35, Burakov, Anatoly:
> Hi Thomas,
>
> > > + }
> > >
> > > else if (!strcmp(lgopts[option_index].name,
> >
> > OPT_CREATE_UIO_DEV))
> >
> > another code style issue reported by checkpatch.pl ;)
> >
> > But it should be fixed by removing this code as Stephen suggests.
>
> I'm not sure this could should be removed. Igb_uio allows to pick interrupt
> mode, so why not VFIO? I've modified my code to try all interrupt modes if
> nothing was explicitly specified, but why should that preclude the user
> from selecting a specific interrupt type if he so desires?
>
> As for the style error - the whole chunk of code uses the same style there,
> so either we fix all of that (in a separate patch?), or leave it as it is.
OK to leave it as is.
But please, let's try to keep a clean code style.
About existing code style issues, separated patches for cleaning should be
well accepted.
Thanks
--
Thomas
More information about the dev
mailing list